diff options
| author | Eric Wong <e@80x24.org> | 2020-12-08 21:21:25 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2020-12-09 21:13:31 +0000 |
| commit | e3b57fe9f68e80fc85cff46ccec9246b670f1312 (patch) | |
| tree | 826706be86815a62083ad953a2bbbb9f325cf670 /xt | |
| parent | 7e34a2145230eb97347ee8f1e63e79eb988a1946 (diff) | |
| download | public-inbox-e3b57fe9f68e80fc85cff46ccec9246b670f1312.tar.gz | |
{ibx} is shorter and is the most prevalent abbreviation
in indexing and IMAP code, and the `$ibx' local variable
is already prevalent throughout.
In general, the codebase favors removal of vowels in variable
and field names to denote non-references (because references are
"lighter" than non-references).
So update WWW and Filter users to use the same code since
it reduces confusion and may allow easier code sharing.
Diffstat (limited to 'xt')
| -rw-r--r-- | xt/cmp-msgview.t | 2 | ||||
| -rw-r--r-- | xt/perf-msgview.t | 2 | ||||
| -rw-r--r-- | xt/perf-threading.t | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/xt/cmp-msgview.t b/xt/cmp-msgview.t index 5bd7aa17..24151267 100644 --- a/xt/cmp-msgview.t +++ b/xt/cmp-msgview.t @@ -24,7 +24,7 @@ vec(my $vec = '', fileno($fh), 1) = 1; select($vec, undef, undef, 60) or die "timed out waiting for --batch-check"; my $mime_ctx = { env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'https' }, - -inbox => $ibx, + ibx => $ibx, www => Plack::Util::inline_object(style => sub {''}), obuf => \(my $mime_buf = ''), mhref => '../', diff --git a/xt/perf-msgview.t b/xt/perf-msgview.t index d99101a3..30e133d7 100644 --- a/xt/perf-msgview.t +++ b/xt/perf-msgview.t @@ -29,7 +29,7 @@ select($vec, undef, undef, 60) or die "timed out waiting for --batch-check"; my $ctx = { env => { HTTP_HOST => 'example.com', 'psgi.url_scheme' => 'https' }, - -inbox => $ibx, + ibx => $ibx, www => Plack::Util::inline_object(style => sub {''}), }; my ($mime, $res, $oid, $type); diff --git a/xt/perf-threading.t b/xt/perf-threading.t index b27c9cbd..472c1953 100644 --- a/xt/perf-threading.t +++ b/xt/perf-threading.t @@ -25,7 +25,7 @@ ok($n, 'got some messages'); diag "enquire: ".timestr($elapsed)." for $n"; $elapsed = timeit(1, sub { - PublicInbox::View::thread_results({-inbox => $ibx}, $msgs); + PublicInbox::View::thread_results({ibx => $ibx}, $msgs); }); diag "thread_results ".timestr($elapsed); |