diff options
author | Eric Wong <e@80x24.org> | 2019-06-29 06:34:40 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-06-29 06:39:45 +0000 |
commit | f2eaf5c929e6a3891b55195cbcaba99d16424933 (patch) | |
tree | 5ff5952504714645d44591a11b69b6e73129434f /t | |
parent | 2b2a247c6cec99784e3e92bb025555c93f5701f3 (diff) | |
download | public-inbox-f2eaf5c929e6a3891b55195cbcaba99d16424933.tar.gz |
We need to ensure we run lsof on the sleep(1) process, and not the fork of ourselves before execve(2). This race applies when we're using the default pure-Perl spawn() implementation.
Diffstat (limited to 't')
-rw-r--r-- | t/ds-leak.t | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/t/ds-leak.t b/t/ds-leak.t index dd8446dc..34ffc125 100644 --- a/t/ds-leak.t +++ b/t/ds-leak.t @@ -15,9 +15,21 @@ if ('close-on-exec for epoll and kqueue') { PublicInbox::DS->SetLoopTimeout(0); PublicInbox::DS->SetPostLoopCallback(sub { 0 }); + + # make sure execve closes if we're using fork() + my ($r, $w); + pipe($r, $w) or die "pipe: $!"; + PublicInbox::DS->AddTimer(0, sub { $pid = spawn([qw(sleep 10)]) }); PublicInbox::DS->EventLoop; ok($pid, 'subprocess spawned'); + + # wait for execve, we need to ensure lsof sees sleep(1) + # and not the fork of this process: + close $w or die "close: $!"; + my $l = <$r>; + is($l, undef, 'cloexec works and sleep(1) is running'); + my @of = grep(/$evfd_re/, `lsof -p $pid 2>/dev/null`); my $err = $?; SKIP: { |