about summary refs log tree commit homepage
path: root/t
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-04-29 04:00:24 +0000
committerEric Wong <e@80x24.org>2016-04-29 07:04:39 +0000
commite901b85c67912a3fd8d17ac0460a57029439f71d (patch)
treeb37babe121047040f41a8542ef3d90edec87a782 /t
parentd456eb0201550050f8ffa0aa279684976cb942a6 (diff)
downloadpublic-inbox-e901b85c67912a3fd8d17ac0460a57029439f71d.tar.gz
We must use a normal write instead of send(.., MSG_MORE)
when writing responses of "Content-Length: 0" to avoid
the corking effect MSG_MORE provides.  We only want to
cork headers if we will send a non-empty body.

Fixes: c3eeaf664cf0 ("http: clarify intent for persistence")
This needs a proper test.
Diffstat (limited to 't')
-rw-r--r--t/httpd-corner.psgi2
-rw-r--r--t/httpd-corner.t13
2 files changed, 15 insertions, 0 deletions
diff --git a/t/httpd-corner.psgi b/t/httpd-corner.psgi
index da8a2ee8..2f7be832 100644
--- a/t/httpd-corner.psgi
+++ b/t/httpd-corner.psgi
@@ -56,6 +56,8 @@ my $app = sub {
                         $fh->write($buf);
                         $fh->close;
                 }
+        } elsif ($path eq '/empty') {
+                $code = 200;
         }
 
         [ $code, $h, $body ]
diff --git a/t/httpd-corner.t b/t/httpd-corner.t
index b64f334a..b9eaa6fb 100644
--- a/t/httpd-corner.t
+++ b/t/httpd-corner.t
@@ -5,6 +5,7 @@
 use strict;
 use warnings;
 use Test::More;
+use Time::HiRes qw(gettimeofday tv_interval);
 
 foreach my $mod (qw(Plack::Util Plack::Request Plack::Builder Danga::Socket
                         HTTP::Date HTTP::Status)) {
@@ -275,6 +276,18 @@ SKIP: {
 }
 
 {
+        my $conn = conn_for($sock, 'no TCP_CORK on empty body');
+        $conn->write("GET /empty HTTP/1.1\r\nHost:example.com\r\n\r\n");
+        my $buf = '';
+        my $t0 = [ gettimeofday ];
+        until ($buf =~ /\r\n\r\n/s) {
+                $conn->sysread($buf, 4096, length($buf));
+        }
+        my $elapsed = tv_interval($t0, [ gettimeofday ]);
+        ok($elapsed < 0.190, 'no 200ms TCP cork delay on empty body');
+}
+
+{
         my $conn = conn_for($sock, 'graceful termination during slow request');
         $conn->write("PUT /sha1 HTTP/1.0\r\n");
         delay();