diff options
author | Eric Wong <e@80x24.org> | 2022-07-22 20:18:09 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2022-07-28 08:11:59 +0000 |
commit | 4eee5af6011cc8cdefb66c9729952c7eff5c0b0b (patch) | |
tree | 461b6ebe1424fffed0c450d98602532c60350b19 /t | |
parent | d0bc58517c97c8982fdf42533297d96be9efb484 (diff) | |
download | public-inbox-4eee5af6011cc8cdefb66c9729952c7eff5c0b0b.tar.gz |
Apparently, --subject doesn't work[1] with "git send-email" in this context. So drop the CLI arg and add a note to tell the user to set a "Subject:" line in their response body, instead. [1] I'm not sure if --subject ever worked as I thought it would, or if it's a regression. In either case, there are current versions of git where it doesn't, so just tell users to use the currently supported method. Link: https://80x24.org/lore/git/CAC4O8c-Tf11CpwuRudyrpXv5bGshuyEenV9kKrs0zRWER-+yHA@mail.gmail.com/
Diffstat (limited to 't')
-rw-r--r-- | t/reply.t | 10 |
1 files changed, 2 insertions, 8 deletions
@@ -38,7 +38,6 @@ my $exp = [ '--to=from@example.com', '--cc=cc@example.com', '--cc=to@example.com', - "--subject='Re: hihi'" ]; is_deeply($arg, $exp, 'default reply is to :all'); @@ -46,8 +45,7 @@ $ibx->{replyto} = ':all'; ($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr); is_deeply($arg, $exp, '":all" also works'); -$exp = [ '--in-reply-to=blah@example.com', '--to=primary@example.com', - "--subject='Re: hihi'" ]; +$exp = [ '--in-reply-to=blah@example.com', '--to=primary@example.com' ]; $ibx->{replyto} = ':list'; ($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr); is_deeply($arg, $exp, '":list" works for centralized lists'); @@ -57,7 +55,6 @@ $exp = [ '--to=primary@example.com', '--cc=cc@example.com', '--cc=to@example.com', - "--subject='Re: hihi'" ]; $ibx->{replyto} = ':list,Cc,To'; ($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr); @@ -65,9 +62,7 @@ is_deeply($arg, $exp, '":list,Cc,To" works for kinda centralized lists'); $ibx->{replyto} = 'new@example.com'; ($arg, $link) = PublicInbox::Reply::mailto_arg_link($ibx, $hdr); -$exp = [ '--in-reply-to=blah@example.com', '--to=new@example.com', - "--subject='Re: hihi'" -]; +$exp = [ '--in-reply-to=blah@example.com', '--to=new@example.com' ]; is_deeply($arg, $exp, 'explicit address works, too'); $ibx->{replyto} = ':all'; @@ -78,7 +73,6 @@ $exp = [ '--to=from@example$(echo .)com', '--cc=cc@example$(echo .)com', '--cc=to@example$(echo .)com', - "--subject='Re: hihi'" ]; is_deeply($arg, $exp, 'address obfuscation works'); is($link, '', 'no mailto: link given'); |