lei: rename "extinbox" => "external"

The words "extinbox" and "extindex" are too close and easy to
confuse with the other.  Rename "extinbox" to "external", since
these could be IMAP, JMAP or other non-public-inbox search APIs.

Link: https://public-inbox.org/meta/20201226112649.GB6226@dcvr/

2 files changed, 12 insertions, 12 deletions

diff --git a/t/lei.t b/t/lei.t
index a95a0efc..764a7fe4 100644
--- a/t/lei.t
+++ b/t/lei.t
@@ -154,38 +154,38 @@ my $setup_publicinboxes = sub {
         $seen || BAIL_OUT 'no imports';
 };
 
-my $test_extinbox = sub {
+my $test_external = sub {
         $setup_publicinboxes->();
         $cleanup->();
-        $lei->('ls-extinbox');
-        is($out.$err, '', 'ls-extinbox no output, yet');
+        $lei->('ls-external');
+        is($out.$err, '', 'ls-external no output, yet');
         ok(!-e $config_file && !-e $store_dir,
-                'nothing created by ls-extinbox');
+                'nothing created by ls-external');
 
         my $cfg = PublicInbox::Config->new;
         $cfg->each_inbox(sub {
                 my ($ibx) = @_;
-                ok($lei->(qw(add-extinbox -q), $ibx->{inboxdir}),
-                        'added extinbox');
+                ok($lei->(qw(add-external -q), $ibx->{inboxdir}),
+                        'added external');
                 is($out.$err, '', 'no output');
         });
         ok(-s $config_file && -e $store_dir,
-                'add-extinbox created config + store');
+                'add-external created config + store');
         my $lcfg = PublicInbox::Config->new($config_file);
         $cfg->each_inbox(sub {
                 my ($ibx) = @_;
-                is($lcfg->{"extinbox.$ibx->{inboxdir}.boost"}, 0,
+                is($lcfg->{"external.$ibx->{inboxdir}.boost"}, 0,
                         "configured boost on $ibx->{name}");
         });
-        $lei->('ls-extinbox');
-        like($out, qr/boost=0\n/s, 'ls-extinbox has output');
+        $lei->('ls-external');
+        like($out, qr/boost=0\n/s, 'ls-external has output');
 };
 
 my $test_lei_common = sub {
         $test_help->();
         $test_config->();
         $test_init->();
-        $test_extinbox->();
+        $test_external->();
 };
 
 my $test_lei_oneshot = $ENV{TEST_LEI_ONESHOT};
diff --git a/t/lei_xsearch.t b/t/lei_xsearch.t
index c41213bd..178c3d37 100644
--- a/t/lei_xsearch.t
+++ b/t/lei_xsearch.t
@@ -49,7 +49,7 @@ $eidx->eidx_sync({fsync => 0});
 my $es = PublicInbox::ExtSearch->new("$home/eidx");
 my $lxs = PublicInbox::LeiXSearch->new;
 for my $ibxish (shuffle($es, @ibx)) {
-        $lxs->attach_extinbox($ibxish);
+        $lxs->attach_external($ibxish);
 }
 my $nr = $lxs->xdb->get_doccount;
 my $mset = $lxs->mset('d:19931002..19931003', { limit => $nr });