view: refactor $state as a hash

Using hash means we no longer have to document and remember what
every field does.  The original array form was insane premature
optimization and crazy.  Who wrote that?  Oh wait, I was on
drugs :<

1 files changed, 5 insertions, 5 deletions

diff --git a/t/view.t b/t/view.t
index ca456aab..fd3c75be 100644
--- a/t/view.t
+++ b/t/view.t
@@ -41,7 +41,7 @@ EOF
                 body => $body,
         )->as_string;
         my $mime = Email::MIME->new($s);
-        my $html = PublicInbox::View->msg_html($mime);
+        my $html = PublicInbox::View::msg_html(undef, $mime);
 
         # ghetto tests
         like($html, qr!<a\nhref="\.\./m/hello%40!s, "MID link present");
@@ -53,7 +53,7 @@ EOF
         # short page
         my $pfx = "http://example.com/test/f";
         $mime = Email::MIME->new($s);
-        my $short = PublicInbox::View->msg_html($mime, $pfx);
+        my $short = PublicInbox::View::msg_html(undef, $mime, $pfx);
         like($short, qr!<a\nhref="hello%40!s, "MID link present");
         like($short, qr/\n&gt; keep this inline/,
                 "short quoted text is inline");
@@ -84,7 +84,7 @@ EOF
                 parts => $parts,
         );
 
-        my $html = PublicInbox::View->msg_html($mime);
+        my $html = PublicInbox::View::msg_html(undef, $mime);
         like($html, qr/hi\n-+ part #2 -+\nbye\n/, "multipart split");
 }
 
@@ -113,7 +113,7 @@ EOF
                 parts => $parts,
         );
 
-        my $html = PublicInbox::View->msg_html($mime);
+        my $html = PublicInbox::View::msg_html(undef, $mime);
         like($html, qr!see attached patch\n-+ foo\.patch -+\n--- a/file\n!,
                 "parts split with filename");
 }
@@ -139,7 +139,7 @@ EOF
         );
 
         my $orig = $mime->body_raw;
-        my $html = PublicInbox::View->msg_html($mime);
+        my $html = PublicInbox::View::msg_html(undef, $mime);
         like($orig, qr/hi =3D bye=/, "our test used QP correctly");
         like($html, qr/\bhi = bye\b/, "HTML output decoded QP");
 }