about summary refs log tree commit homepage
path: root/t
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-05-19 22:02:56 +0000
committerEric Wong <e@80x24.org>2016-05-19 22:02:56 +0000
commitd6cdb106f27abed5d05da035c95e106939fbe3b2 (patch)
tree512df7bdbcd4b4f91af64a4ef9d9d645867a072b /t
parent9c54a95e5279826fb8a768f7d6b45cc475415f84 (diff)
downloadpublic-inbox-d6cdb106f27abed5d05da035c95e106939fbe3b2.tar.gz
Having a file start with '.' or '-' can be confusing
and for users, so do not allow it.
Diffstat (limited to 't')
-rw-r--r--t/psgi_attach.t17
1 files changed, 16 insertions, 1 deletions
diff --git a/t/psgi_attach.t b/t/psgi_attach.t
index 43018e85..ef116c6a 100644
--- a/t/psgi_attach.t
+++ b/t/psgi_attach.t
@@ -36,6 +36,7 @@ my $im = PublicInbox::Import->new($git, 'test', $addr);
         my $qp = "abcdef=g\n==blah\n";
         my $b64 = 'b64'.$buf."\n";
         my $txt = "plain\ntext\npass\nthrough\n";
+        my $dot = "dotfile\n";
         my $parts = [
                 Email::MIME->create(
                         attributes => {
@@ -57,6 +58,12 @@ my $im = PublicInbox::Import->new($git, 'test', $addr);
                                 content_type => 'text/plain',
                         },
                         body => $txt),
+                Email::MIME->create(
+                        attributes => {
+                                filename => '.dotfile',
+                                content_type => 'text/plain',
+                        },
+                        body => $dot),
         ];
         my $mime = Email::MIME->create(
                 parts => $parts,
@@ -76,7 +83,8 @@ my $im = PublicInbox::Import->new($git, 'test', $addr);
                 $res = $cb->(GET('/test/Z%40B/'));
                 my @href = ($res->content =~ /^href="([^"]+)"/gms);
                 @href = grep(/\A[\d\.]+-/, @href);
-                is_deeply([qw(1-queue-pee 2-bayce-sixty-four 3-noop.txt)],
+                is_deeply([qw(1-queue-pee 2-bayce-sixty-four 3-noop.txt
+                                4-a.txt)],
                         \@href, 'attachment links generated');
 
                 $res = $cb->(GET('/test/Z%40B/1-queue-pee'));
@@ -97,6 +105,13 @@ my $im = PublicInbox::Import->new($git, 'test', $addr);
                         'plain text almost matches');
                 like($txt_res, qr/\n\z/s, 'trailing newline exists in text');
                 is(index($txt_res, $txt), 0, 'plain text not truncated');
+
+                $res = $cb->(GET('/test/Z%40B/4-a.txt'));
+                my $dot_res = $res->content;
+                ok(length($dot_res) >= length($dot), 'dot almost matches');
+                $res = $cb->(GET('/test/Z%40B/4-any-filename.txt'));
+                is($res->content, $dot_res, 'user-specified filename is OK');
+
         });
 }
 done_testing();