diff options
author | Eric Wong <e@80x24.org> | 2021-01-01 19:13:39 -1400 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2021-01-02 22:38:49 +0000 |
commit | 6dd3c17ed185c0ed4569541dae52e0570be4deca (patch) | |
tree | e5b694ec690130e288361b1131959de3363195b0 /t/spawn.t | |
parent | 0bd668ac6f15f791b626f5c644d23952c377b200 (diff) | |
download | public-inbox-6dd3c17ed185c0ed4569541dae52e0570be4deca.tar.gz |
To get rid of the ugly $PublicInbox::DS::in_loop localization in MboxReader, we'll distinguish between ->CLOSE and ->DESTROY with ProcessPipe. If we end up closing via ->DESTROY, we'll assume the caller will want to deal with $? asynchronously via the event loop (or not even care about $?). If we hit ->CLOSE directly, we'll assume the caller called close() and wants to check $? synchronously. Note: wantarray doesn't seem to propagate into tied methods, otherwise I'd be relying on that.
Diffstat (limited to 't/spawn.t')
-rw-r--r-- | t/spawn.t | 38 |
1 files changed, 38 insertions, 0 deletions
@@ -98,6 +98,44 @@ EOF isnt($?, 0, '$? set properly: '.$?); } +{ # ->CLOSE vs ->DESTROY waitpid caller distinction + my @c; + my $fh = popen_rd(['true'], undef, { cb => sub { @c = caller } }); + ok(close($fh), '->CLOSE fired and successful'); + ok(scalar(@c), 'callback fired by ->CLOSE'); + ok(grep(!m[/PublicInbox/DS\.pm\z], @c), 'callback not invoked by DS'); + + @c = (); + $fh = popen_rd(['true'], undef, { cb => sub { @c = caller } }); + undef $fh; # ->DESTROY + ok(scalar(@c), 'callback fired by ->DESTROY'); + ok(grep(!m[/PublicInbox/ProcessPipe\.pm\z], @c), + 'callback not invoked by ProcessPipe'); +} + +{ # children don't wait on siblings + use POSIX qw(_exit); + pipe(my ($r, $w)) or BAIL_OUT $!; + my $cb = sub { warn "x=$$\n" }; + my $fh = popen_rd(['cat'], undef, { 0 => $r, cb => $cb }); + my $pp = tied *$fh; + my $pid = fork // BAIL_OUT $!; + local $SIG{__WARN__} = sub { _exit(1) }; + if ($pid == 0) { + local $SIG{__DIE__} = sub { _exit(2) }; + undef $fh; + _exit(0); + } + waitpid($pid, 0); + is($?, 0, 'forked process exited'); + my @w; + local $SIG{__WARN__} = sub { push @w, @_ }; + close $w; + close $fh; + is($?, 0, 'cat exited'); + is_deeply(\@w, [ "x=$$\n" ], 'callback fired from owner'); +} + SKIP: { eval { require BSD::Resource; |