v2writable: initializing an existing inbox is idempotent

And we do not want to start making confused repos if somebody
leaves out "-V2" the second time around.

1 files changed, 30 insertions, 2 deletions

diff --git a/t/init.t b/t/init.t
index 6ae608e5..59f54813 100644
--- a/t/init.t
+++ b/t/init.t
@@ -7,6 +7,23 @@ use PublicInbox::Config;
 use File::Temp qw/tempdir/;
 my $tmpdir = tempdir('pi-init-XXXXXX', TMPDIR => 1, CLEANUP => 1);
 use constant pi_init => 'blib/script/public-inbox-init';
+use PublicInbox::Import;
+use File::Basename;
+open my $null, '>>', '/dev/null';
+my $rdr = { 2 => fileno($null) };
+sub quiet_fail {
+        my ($cmd, $msg) = @_;
+        # run_die doesn't take absolute paths:
+        my $path = $ENV{PATH};
+        if (index($cmd->[0], '/') >= 0) {
+                my ($dir, $base) = ($cmd->[0] =~ m!\A(.+)/([^/]+)\z!);
+                $path = "$dir:$path";
+                $cmd->[0] = $base;
+        }
+        local $ENV{PATH} = $path;
+        eval { PublicInbox::Import::run_die($cmd, undef, $rdr) };
+        isnt($@, '', $msg);
+}
 
 {
         local $ENV{PI_DIR} = "$tmpdir/.public-inbox/";
@@ -23,6 +40,10 @@ use constant pi_init => 'blib/script/public-inbox-init';
                    qw(http://example.com/clist clist@example.com));
         is(system(@cmd), 0, 'public-inbox-init clist OK');
         is((stat($cfgfile))[2] & 07777, 0666, "permissions preserved");
+
+        @cmd = (pi_init, 'clist', '-V2', "$tmpdir/clist",
+                   qw(http://example.com/clist clist@example.com));
+        quiet_fail(\@cmd, 'attempting to init V2 from V1 fails');
 }
 
 SKIP: {
@@ -38,8 +59,15 @@ SKIP: {
         ok(-d "$tmpdir/v2list", 'v2list directory exists');
         ok(-f "$tmpdir/v2list/msgmap.sqlite3", 'msgmap exists');
         ok(-d "$tmpdir/v2list/all.git", 'catch-all.git directory exists');
-        @cmd = (qw(git config), "--file=$tmpdir/v2list/all.git/config",
-                qw(core.sharedRepository 0644));
+        @cmd = (pi_init, 'v2list', "$tmpdir/v2list",
+                   qw(http://example.com/v2list v2list@example.com));
+        is(system(@cmd), 0, 'public-inbox-init is idempotent');
+        ok(! -d "$tmpdir/public-inbox" && !-d "$tmpdir/objects",
+                'idempotent invocation w/o -V2 does not make inbox v1');
+
+        @cmd = (pi_init, 'v2list', "-V1", "$tmpdir/v2list",
+                   qw(http://example.com/v2list v2list@example.com));
+        quiet_fail(\@cmd, 'initializing V2 as V1 fails');
 }
 
 done_testing();