about summary refs log tree commit homepage
path: root/t/git.t
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-02-07 23:05:20 -1000
committerEric Wong <e@80x24.org>2021-02-08 22:07:50 +0000
commitecd4e2e20f1af200697e54c2a322a459cdf4c5fc (patch)
treeb7c532d20f6cd02f8280a9b3d533d5e4ebe6e4c0 /t/git.t
parentfbb7ccabbf54a4054e583dfabc4d0c4cbe2844cb (diff)
downloadpublic-inbox-ecd4e2e20f1af200697e54c2a322a459cdf4c5fc.tar.gz
This is necessary to avoid slowdowns with pathological cases
with many dates in the query, since each rev-parse invocation
takes ~5ms.

This is immeasurably slower with one open-ended range, but
already faster with any closed range featuring two dates which
require parsing via git.
Diffstat (limited to 't/git.t')
-rw-r--r--t/git.t16
1 files changed, 9 insertions, 7 deletions
diff --git a/t/git.t b/t/git.t
index 7b950d88..4a45bbaf 100644
--- a/t/git.t
+++ b/t/git.t
@@ -20,14 +20,16 @@ use_ok 'PublicInbox::Git';
 }
 {
         my $git = PublicInbox::Git->new($dir);
-        my $s = $git->date_parse('1970-01-01T00:00:00Z');
-        is($s, 0, 'parsed epoch');
+        my @s = $git->date_parse('1970-01-01T00:00:00Z');
+        is($s[0], 0, 'parsed epoch');
         local $ENV{TZ} = 'UTC';
-        $s = $git->date_parse('1993-10-02 01:02:09');
-        is(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($s)), '1993-10-02T01:02:09Z',
-                'round trips');
-        $s = $git->date_parse('1993-10-02');
-        is(strftime('%Y-%m-%d', gmtime($s)), '1993-10-02',
+        @s = $git->date_parse('1993-10-02 01:02:09', '2010-10-02 01:03:04');
+        is(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($s[0])),
+                '1993-10-02T01:02:09Z', 'round trips');
+        is(strftime('%Y-%m-%dT%H:%M:%SZ', gmtime($s[1])),
+                '2010-10-02T01:03:04Z', '2nd arg round trips');
+        @s = $git->date_parse('1993-10-02');
+        is(strftime('%Y-%m-%d', gmtime($s[0])), '1993-10-02',
                 'round trips date-only');
 }