about summary refs log tree commit homepage
path: root/t/feed.t
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-02-06 20:59:45 +0000
committerEric Wong <e@yhbt.net>2020-02-07 07:21:18 +0000
commita3cf35c675217ea60a461dd9be7cc5b55c2d5280 (patch)
treebc35aa6d2dc279f66c9156f6865d80321522786b /t/feed.t
parent17e52476687e03fecd579f765ad6864cde0f4203 (diff)
downloadpublic-inbox-a3cf35c675217ea60a461dd9be7cc5b55c2d5280.tar.gz
XML::Feed pulls in a lot of dependencies, some of which XS.
That makes testing with blead or any non-OS-supplied Perl
installations more time consuming and more difficult because
of the need to have development headers and libraries for
libexpat1 or libxml2.

Performance from libexpat1 or libxml2 for our small tests cases
isn't relevant, either, and the pure Perl XML::TreePP seems up
to the task.  It's also available in CentOS 7.x, FreeBSD 11.x,
and Debian, at least.
Diffstat (limited to 't/feed.t')
-rw-r--r--t/feed.t36
1 files changed, 21 insertions, 15 deletions
diff --git a/t/feed.t b/t/feed.t
index 5333d582..cfa09a7c 100644
--- a/t/feed.t
+++ b/t/feed.t
@@ -7,7 +7,7 @@ use Email::MIME;
 use PublicInbox::Feed;
 use PublicInbox::Import;
 use PublicInbox::Inbox;
-my $have_xml_feed = eval { require XML::Feed; 1 };
+my $have_xml_treepp = eval { require XML::TreePP; 1 };
 use PublicInbox::TestCommon;
 
 sub string_feed {
@@ -79,12 +79,14 @@ EOF
         {
                 my $feed = string_feed({ -inbox => $ibx });
                 SKIP: {
-                        skip 'XML::Feed missing', 2 unless $have_xml_feed;
-                        my $p = XML::Feed->parse(\$feed);
-                        is($p->format, "Atom", "parsed atom feed");
-                        is(scalar $p->entries, 3, "parsed three entries");
-                        is($p->id, 'mailto:test@example',
-                                "id is set to default");
+                        skip 'XML::TreePP missing', 3 unless $have_xml_treepp;
+                        my $t = XML::TreePP->new->parse($feed);
+                        like($t->{feed}->{-xmlns}, qr/\bAtom\b/,
+                                'looks like an an Atom feed');
+                        is(scalar @{$t->{feed}->{entry}}, 3,
+                                'parsed three entries');
+                        is($t->{feed}->{id}, 'mailto:test@example',
+                                'id is set to default');
                 }
 
                 like($feed, qr/drop me/, "long quoted text kept");
@@ -111,10 +113,12 @@ EOF
         {
                 my $spammy_feed = string_feed({ -inbox => $ibx });
                 SKIP: {
-                        skip 'XML::Feed missing', 2 unless $have_xml_feed;
-                        my $p = XML::Feed->parse(\$spammy_feed);
-                        is($p->format, "Atom", "parsed atom feed");
-                        is(scalar $p->entries, 3, "parsed three entries");
+                        skip 'XML::TreePP missing', 2 unless $have_xml_treepp;
+                        my $t = XML::TreePP->new->parse($spammy_feed);
+                        like($t->{feed}->{-xmlns}, qr/\bAtom\b/,
+                                'looks like an an Atom feed');
+                        is(scalar @{$t->{feed}->{entry}}, 3,
+                                'parsed three entries');
                 }
                 like($spammy_feed, qr/SPAM/s, "spam showed up :<");
         }
@@ -127,10 +131,12 @@ EOF
         {
                 my $feed = string_feed({ -inbox => $ibx });
                 SKIP: {
-                        skip 'XML::Feed missing', 2 unless $have_xml_feed;
-                        my $p = XML::Feed->parse(\$feed);
-                        is($p->format, "Atom", "parsed atom feed");
-                        is(scalar $p->entries, 3, "parsed three entries");
+                        skip 'XML::TreePP missing', 2 unless $have_xml_treepp;
+                        my $t = XML::TreePP->new->parse($feed);
+                        like($t->{feed}->{-xmlns}, qr/\bAtom\b/,
+                                'looks like an an Atom feed');
+                        is(scalar @{$t->{feed}->{entry}}, 3,
+                                'parsed three entries');
                 }
                 unlike($feed, qr/SPAM/, "spam gone :>");
         }