about summary refs log tree commit homepage
path: root/scripts/slrnspool2maildir
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-04-18 03:38:50 +0000
committerEric Wong <e@yhbt.net>2020-04-19 08:51:24 +0000
commita479b45117ed69d9311770fa39e6676d38f9cab2 (patch)
tree9262dbdd0147b02a7d9d9a797271ec25e8aa1c5f /scripts/slrnspool2maildir
parenta014723b600e35cd495f048c89611e611436a15e (diff)
downloadpublic-inbox-a479b45117ed69d9311770fa39e6676d38f9cab2.tar.gz
I did not know to use the return value of `do' back in the day.
There's probably no practical difference in these cases, but
`eval' is overkill for these uses and may hide actual errors.

We can get rid of a few redundant `scalar' ops and pass scalar
refs to Email::MIME->new to avoid copies in a few more places,
too.
Diffstat (limited to 'scripts/slrnspool2maildir')
-rwxr-xr-xscripts/slrnspool2maildir2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/slrnspool2maildir b/scripts/slrnspool2maildir
index 0c21806a..8e444e84 100755
--- a/scripts/slrnspool2maildir
+++ b/scripts/slrnspool2maildir
@@ -23,7 +23,7 @@ foreach my $sub (qw(cur new tmp)) {
 
 foreach my $n (grep(/\d+\z/, glob("$spool/*"))) {
         if (open my $fh, '<', $n) {
-                my $f = Email::Filter->new(data => eval { local $/; <$fh> });
+                my $f = Email::Filter->new(data => do { local $/; <$fh> });
                 my $s = $f->simple;
 
                 # gmane rewrites Received headers, which increases spamminess