about summary refs log tree commit homepage
path: root/script
diff options
authorEric Wong <e@80x24.org>2018-07-29 09:34:41 +0000
committerEric Wong <e@80x24.org>2018-07-29 09:43:06 +0000
commit9015a8af2909b0071e54b332bfafc4e5b8d0f6c2 (patch)
tree7db2a5e86ef3cbf9cd18f948be20df52543c837c /script
parent31eda8c90633766692156c9c0af061dad6299c84 (diff)
We must not clobber the original message string, as Email::MIME(*)
still needs it for iterating through parts in SearchIdx (but not
when handing it as a raw string to git-fast-import).

I've noticed message bodies (especially dfpre/dpost) were not
getting indexed when going through -mda (no problems with
-watch).  This also did not affect v1 repos, since indexing is a
separate process for v1 and requires re-reading the data from

(*) tested Email::MIME 1.937 on Debian stretch
Diffstat (limited to 'script')
1 files changed, 0 insertions, 1 deletions
diff --git a/script/public-inbox-mda b/script/public-inbox-mda
index 2a315378..2b7f298c 100755
--- a/script/public-inbox-mda
+++ b/script/public-inbox-mda
@@ -51,7 +51,6 @@ $emm = PublicInbox::Emergency->new($emergency);
 $ems = $ems->abort;
 my $mime = PublicInbox::MIME->new(\$str);
-$str = '';
 do_exit(0) unless $spam_ok;
 my $fcfg = $dst->{filter} || '';