about summary refs log tree commit homepage
path: root/script/public-inbox-index
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-08-07 01:14:06 +0000
committerEric Wong <e@yhbt.net>2020-08-07 23:45:39 +0000
commit8b1950055d51d4360e596446e5ac0f41008e357d (patch)
tree2fb3195c07e82a62e96bc3841a2f5dbd7da602d6 /script/public-inbox-index
parent99def67b86c4d270e8cfda4d1fad418291b6f3a4 (diff)
downloadpublic-inbox-8b1950055d51d4360e596446e5ac0f41008e357d.tar.gz
We'll continue supporting `--no-sync' even if its yet-to-make it
it into a release, but the term `sync' is overloaded in our
codebase which may be confusing to new hackers and users.

None of our our code nor dependencies issue the sync(2) syscall,
either, only fsync(2) and fdatasync(2).
Diffstat (limited to 'script/public-inbox-index')
-rwxr-xr-xscript/public-inbox-index8
1 files changed, 4 insertions, 4 deletions
diff --git a/script/public-inbox-index b/script/public-inbox-index
index a52fb1bf..dc9bdde1 100755
--- a/script/public-inbox-index
+++ b/script/public-inbox-index
@@ -14,9 +14,9 @@ PublicInbox::Admin::require_or_die('-index');
 use PublicInbox::Xapcmd;
 
 my $compact_opt;
-my $opt = { quiet => -1, compact => 0, maxsize => undef, sync => 1 };
-GetOptions($opt, qw(verbose|v+ reindex rethread compact|c+ jobs|j=i prune sync!
-                xapianonly|xapian-only
+my $opt = { quiet => -1, compact => 0, maxsize => undef, fsync => 1 };
+GetOptions($opt, qw(verbose|v+ reindex rethread compact|c+ jobs|j=i prune
+                fsync|sync! xapianonly|xapian-only
                 indexlevel|L=s maxsize|max-size=s batchsize|batch-size=s
                 sequentialshard|seq-shard|sequential-shard))
         or die "bad command-line args\n$usage";
@@ -73,7 +73,7 @@ for my $ibx (@ibxs) {
         if ($opt->{compact} >= 2) {
                 PublicInbox::Xapcmd::run($ibx, 'compact', $compact_opt);
         }
-        $ibx->{-no_sync} = 1 if !$opt->{sync};
+        $ibx->{-no_fsync} = 1 if !$opt->{fsync};
 
         my $ibx_opt = $opt;
         if (defined(my $s = $ibx->{indexsequentialshard})) {