nntp: fix handling of trickled responses

We cannot use the push_back_read functionality of Danga::Socket
since it will trigger event_read on buffered data.  This would
allow a malicious (or badly implemented) client to burn CPU
without actually sending us anything.

So we still do buffering ourselves and play some tricks with
timers re-enable readability.

1 files changed, 2 insertions, 1 deletions

diff --git a/public-inbox-nntpd b/public-inbox-nntpd
index 588efdd3..b66de58e 100644
--- a/public-inbox-nntpd
+++ b/public-inbox-nntpd
@@ -146,7 +146,8 @@ sub worker_quit {
                 my ($dmap, undef) = @_;
                 my $n = 0;
                 foreach my $s (values %$dmap) {
-                        if ($s->{write_buf_size} || @{$s->{read_push_back}}) {
+                        next unless ref($s) eq 'PublicInbox::NNTP';
+                        if ($s->{write_buf_size} || $s->{rbuf}) {
                                 ++$n;
                         } else {
                                 $s->close;