about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2017-06-23 22:42:34 +0000
committerEric Wong <e@80x24.org>2017-06-23 22:44:52 +0000
commitdfdaf74a2ab6d694315d8f636e3771a7a7934f3f (patch)
tree2caa9cd27b9bbf5020ea1a4b3b4d3bd2d47c4345 /lib
parent1a8eb0a43c68e64b77fdd3c4ebd977a1ab88e71b (diff)
downloadpublic-inbox-dfdaf74a2ab6d694315d8f636e3771a7a7934f3f.tar.gz
Sometimes, URLs exist at the end of parethesized statements,
and we shouldn't unnecessarily capture that.

(example: https://public-inbox.org/ruby-core/20170623032722.GA8124@dcvr/)
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/Linkify.pm6
1 files changed, 4 insertions, 2 deletions
diff --git a/lib/PublicInbox/Linkify.pm b/lib/PublicInbox/Linkify.pm
index 8e1728c7..93c468fe 100644
--- a/lib/PublicInbox/Linkify.pm
+++ b/lib/PublicInbox/Linkify.pm
@@ -25,7 +25,7 @@ my $LINK_RE = qr{(\()?\b((?:ftps?|https?|nntps?|gopher)://
 sub new { bless {}, $_[0] }
 
 sub linkify_1 {
-        $_[1] =~ s!$LINK_RE!
+        $_[1] =~ s^$LINK_RE^
                 my $beg = $1 || '';
                 my $url = $2;
                 my $end = '';
@@ -41,6 +41,8 @@ sub linkify_1 {
                         }
                 } elsif ($url =~ s/([\.,;])\z//) {
                         $end = $1;
+                } elsif ($url !~ /\(/ && $url =~ s/\)\z//) {
+                        $end = ')';
                 }
 
                 # salt this, as this could be exploited to show
@@ -51,7 +53,7 @@ sub linkify_1 {
                 $url =~ s/&/&#38;/g;
                 $_[0]->{$key} = $url;
                 $beg . 'PI-LINK-'. $key . $end;
-        !ge;
+        ^ge;
         $_[1];
 }