about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-01-01 19:13:43 -1400
committerEric Wong <e@80x24.org>2021-01-02 22:38:53 +0000
commit5f6739428f936c520188e6050f62cdd45f453fb3 (patch)
treea61a3c03c223ea8b30db63f2cdeea7a4211acc75 /lib
parentf6fef919f718c9286aa019f277d3c3767e75d2e8 (diff)
downloadpublic-inbox-5f6739428f936c520188e6050f62cdd45f453fb3.tar.gz
Only saves us one line of code, but that's better than nothing.
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/Git.pm7
1 files changed, 3 insertions, 4 deletions
diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index cdd2b400..3d97300c 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -507,14 +507,13 @@ sub modified ($) {
 # templates/this--description in git.git
 sub manifest_entry {
         my ($self, $epoch, $default_desc) = @_;
-        my ($fh, $pid) = $self->popen('show-ref');
+        my $fh = $self->popen('show-ref');
         my $dig = Digest::SHA->new(1);
         while (read($fh, my $buf, 65536)) {
                 $dig->add($buf);
         }
-        close $fh;
-        waitpid($pid, 0);
-        return if $?; # empty, uninitialized git repo
+        close $fh or return; # empty, uninitialized git repo
+        undef $fh; # for open, below
         my $git_dir = $self->{git_dir};
         my $ent = {
                 fingerprint => $dig->hexdigest,