about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-06-20 07:22:24 +0000
committerEric Wong <e@80x24.org>2016-06-20 07:22:53 +0000
commitfad5d3e2eb7aeb782858ddacca7244854cf32167 (patch)
treedf3d4635265d105abd226a05431ca8b008bf9bbb /lib
parent89c33eadfd78b2aacd3e4924cc62a7e3402c35e8 (diff)
downloadpublic-inbox-fad5d3e2eb7aeb782858ddacca7244854cf32167.tar.gz
lookup_mail is safer since it won't inadvertently load ghosts.
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/NNTP.pm6
1 files changed, 2 insertions, 4 deletions
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 93f654f6..4b116a7d 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -711,8 +711,7 @@ sub hdr_xref ($$$) { # optimize XHDR Xref [range] for rtin
 
 sub search_header_for {
         my ($srch, $mid, $field) = @_;
-        my $smsg = $srch->lookup_message($mid) or return;
-        $smsg = PublicInbox::SearchMsg->load_doc($smsg->{doc});
+        my $smsg = $srch->lookup_mail($mid) or return;
         $smsg->$field;
 }
 
@@ -847,10 +846,9 @@ sub cmd_over ($;$) {
         my ($self, $range) = @_;
         if ($range && $range =~ /\A<(.+)>\z/) {
                 my ($ng, $n) = mid_lookup($self, $1);
-                my $smsg = $ng->search->lookup_message($range) or
+                my $smsg = $ng->search->lookup_mail($range) or
                         return '430 No article with that message-id';
                 more($self, '224 Overview information follows (multi-line)');
-                $smsg = PublicInbox::SearchMsg->load_doc($smsg->{doc});
 
                 # Only set article number column if it's the current group
                 my $self_ng = $self->{ng};