about summary refs log tree commit homepage
path: root/lib
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2018-04-25 08:52:49 +0000
committerEric Wong <e@80x24.org>2018-04-25 08:53:03 +0000
commitc204da04aa24e85236f82ba5a7c6c7e19c8a20d3 (patch)
tree35272c2de196ff51585bd1899c0a066d969c1548 /lib
parentec2df4c3b80104a0bf15b0d917d82264bbf9b50e (diff)
downloadpublic-inbox-c204da04aa24e85236f82ba5a7c6c7e19c8a20d3.tar.gz
Improve the display by finding any parent when we see out-of-order
References.  This prevents us from having two roots in the test
case like Mail::Thread does.
Diffstat (limited to 'lib')
-rw-r--r--lib/PublicInbox/SearchThread.pm11
1 files changed, 9 insertions, 2 deletions
diff --git a/lib/PublicInbox/SearchThread.pm b/lib/PublicInbox/SearchThread.pm
index 450a06f4..be290980 100644
--- a/lib/PublicInbox/SearchThread.pm
+++ b/lib/PublicInbox/SearchThread.pm
@@ -22,9 +22,16 @@ use strict;
 use warnings;
 
 sub thread {
-        my ($messages, $ordersub, $ibx) = @_;
+        my ($msgs, $ordersub, $ibx) = @_;
         my $id_table = {};
-        _add_message($id_table, $_) foreach @$messages;
+
+        # Sadly, we sort here anyways since the fill-in-the-blanks References:
+        # can be shakier if somebody used In-Reply-To with multiple, disparate
+        # messages.  So, take the client Date: into account since we can't
+        # alway determine ordering when somebody uses multiple In-Reply-To.
+        # We'll trust the client Date: header here instead of the Received:
+        # time since this is for display (and not retrieval)
+        _add_message($id_table, $_) for sort { $a->{ds} <=> $b->{ds} } @$msgs;
         my $rootset = [ grep {
                         !delete($_->{parent}) && $_->visible($ibx)
                 } values %$id_table ];