about summary refs log tree commit homepage
path: root/lib/PublicInbox
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-07-14 02:14:30 +0000
committerEric Wong <e@yhbt.net>2020-07-14 23:22:56 +0000
commite9fc1290ead44e06d20ff58e0a6acb5306d4fbe2 (patch)
tree0ad529ad52537e808955e78560f7d7d9e86be040 /lib/PublicInbox
parent2a5ffae959ebe49dbfbff809db1aa798ceae4228 (diff)
downloadpublic-inbox-e9fc1290ead44e06d20ff58e0a6acb5306d4fbe2.tar.gz
None of the human-readable strings stored in over.sqlite3
require UTF-8.  Message-IDs do not, nor do the compressed
Subject IDs (sid) we use for Subject-based threading.  And the
`ddd' (doc-data-deflated) column is of course binary data.

This frees us of having to use SQL_BLOB for the `ddd', column,
and will open the door for us to use dbh_new for Msgmap, too.
Diffstat (limited to 'lib/PublicInbox')
-rw-r--r--lib/PublicInbox/Over.pm1
-rw-r--r--lib/PublicInbox/OverIdx.pm4
2 files changed, 2 insertions, 3 deletions
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index e5a980d5..5d285057 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -36,7 +36,6 @@ sub dbh_new {
                 $st = pack('dd', $st[0], $st[1]);
         } while ($st ne $self->{st} && $tries++ < 3);
         warn "W: $f: .st_dev, .st_ino unstable\n" if $st ne $self->{st};
-        $dbh->{sqlite_unicode} = 1;
         $dbh;
 }
 
diff --git a/lib/PublicInbox/OverIdx.pm b/lib/PublicInbox/OverIdx.pm
index 008a5d1a..13aa2d74 100644
--- a/lib/PublicInbox/OverIdx.pm
+++ b/lib/PublicInbox/OverIdx.pm
@@ -12,7 +12,7 @@ use strict;
 use warnings;
 use base qw(PublicInbox::Over);
 use IO::Handle;
-use DBI qw(:sql_types); # SQL_BLOB
+use DBI;
 use PublicInbox::MID qw/id_compress mids_for_index references/;
 use PublicInbox::Smsg qw(subject_normalized);
 use Compress::Zlib qw(compress);
@@ -309,7 +309,7 @@ VALUES (?,?,?,?,?,?)
         my $n = 0;
         my @v = ($num, $tid, $sid, $ts, $ds);
         foreach (@v) { $sth->bind_param(++$n, $_) }
-        $sth->bind_param(++$n, $ddd, SQL_BLOB);
+        $sth->bind_param(++$n, $ddd);
         $sth->execute;
         $sth = $dbh->prepare_cached(<<'');
 INSERT INTO id2num (id, num) VALUES (?,?)