diff options
| author | Eric Wong <e@80x24.org> | 2016-07-06 02:32:07 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2016-07-06 07:12:45 +0000 |
| commit | 8a770e2b8ec58bb3ac283aeaa97a4fddba3b03f9 (patch) | |
| tree | 48078bfdf054c3e3dd3737db084ef479b687bfc6 /lib/PublicInbox | |
| parent | de92f32ad9d7c46db4d9e70fe441576b89aa0f5a (diff) | |
| download | public-inbox-8a770e2b8ec58bb3ac283aeaa97a4fddba3b03f9.tar.gz | |
www: use HTML <hr> instead of XHTML <hr />
We only need XHTML-compatibility inside Atom feeds, as anecdotally, feed readers are stricter than normal browsers and some do not support HTML, only XHTML. So we will continue to accomodate them. However we favor HTML elsewhere since it tends to be smaller than the equivalent well-formed XHTML.
Diffstat (limited to 'lib/PublicInbox')
| -rw-r--r-- | lib/PublicInbox/Feed.pm | 2 | ||||
| -rw-r--r-- | lib/PublicInbox/SearchView.pm | 6 | ||||
| -rw-r--r-- | lib/PublicInbox/Unsubscribe.pm | 2 | ||||
| -rw-r--r-- | lib/PublicInbox/View.pm | 5 |
4 files changed, 7 insertions, 8 deletions
diff --git a/lib/PublicInbox/Feed.pm b/lib/PublicInbox/Feed.pm index 2983514c..1f88abaa 100644 --- a/lib/PublicInbox/Feed.pm +++ b/lib/PublicInbox/Feed.pm @@ -188,7 +188,7 @@ sub emit_html_index { if ($footer) { my $list_footer = $ctx->{footer}; $footer .= "\n\n" . $list_footer if $list_footer; - $footer = "<hr /><pre>$footer</pre>"; + $footer = "<hr><pre>$footer</pre>"; } $fh->write("$footer</body></html>"); $fh->close; diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm index 15bb8232..80a2ff7c 100644 --- a/lib/PublicInbox/SearchView.pm +++ b/lib/PublicInbox/SearchView.pm @@ -38,11 +38,11 @@ sub sres_top_html { my $cb; if ($err) { $code = 400; - $ctx->{-html_tip} = '<pre>'.err_txt($ctx, $err).'</pre><hr />'; + $ctx->{-html_tip} = '<pre>'.err_txt($ctx, $err).'</pre><hr>'; $cb = *noop; } elsif ($total == 0) { $code = 404; - $ctx->{-html_tip} = "<pre>\n[No results found]</pre><hr />"; + $ctx->{-html_tip} = "<pre>\n[No results found]</pre><hr>"; $cb = *noop; } else { my $x = $q->{x}; @@ -126,7 +126,7 @@ sub search_nav_bot { my $o = $q->{o}; my $end = $o + $nr; my $beg = $o + 1; - my $rv = "</pre><hr /><pre>Results $beg-$end of $total"; + my $rv = "</pre><hr><pre>Results $beg-$end of $total"; my $n = $o + $LIM; if ($n < $total) { diff --git a/lib/PublicInbox/Unsubscribe.pm b/lib/PublicInbox/Unsubscribe.pm index 46d5d8d7..fca300e5 100644 --- a/lib/PublicInbox/Unsubscribe.pm +++ b/lib/PublicInbox/Unsubscribe.pm @@ -136,7 +136,7 @@ sub r { my ($self, $code, $title, @body) = @_; [ $code, [ @CT_HTML ], [ "<html><head><title>$title</title></head><body><pre>". - join("\n", "<b>$title</b>\n", @body) . '</pre><hr />'. + join("\n", "<b>$title</b>\n", @body) . '</pre><hr>'. "<pre>This page is available under AGPL-3.0+\n" . "git clone $self->{code_url}\n" . qq(Email $self->{contact} if you have any questions). diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm index c230836d..7ff3b403 100644 --- a/lib/PublicInbox/View.pm +++ b/lib/PublicInbox/View.pm @@ -30,8 +30,7 @@ sub msg_html { PublicInbox::WwwStream->response($ctx, 200, sub { my ($nr, undef) = @_; if ($nr == 1) { - $tip . multipart_text_as_html($mime, '') . - '</pre><hr />' + $tip . multipart_text_as_html($mime, '') . '</pre><hr>' } elsif ($nr == 2) { # fake an EOF if generating the footer fails; # we want to at least show the message if something @@ -321,7 +320,7 @@ sub thread_html { my $msgs = load_results($sres); my $nr = $sres->{total}; return missing_thread($ctx) if $nr == 0; - my $skel = '<hr /><pre>'; + my $skel = '<hr><pre>'; $skel .= $nr == 1 ? 'only message in thread' : 'end of thread'; $skel .= ", back to <a\nhref=\"../../\">index</a>"; $skel .= "\n<a\nid=t>$nr+ messages in thread:</a> (download: "; |