about summary refs log tree commit homepage
path: root/lib/PublicInbox
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-10-01 23:18:02 +0000
committerEric Wong <e@80x24.org>2019-10-02 07:02:52 +0000
commit422cbeb718cf2499cd07c9399755d41aea65b1f8 (patch)
tree7de7b9c867e0f0b6cacc4b66124cdf835d7e3d71 /lib/PublicInbox
parentdbb6c7b51862d0ea7438f5fb393d115ea46f1fab (diff)
downloadpublic-inbox-422cbeb718cf2499cd07c9399755d41aea65b1f8.tar.gz
We need to warn when hitting file or socket memory limits
or misconfigurations which clear O_NONBLOCK to make it easier
to diagnose configuration problems.  We'll also warn on
some other errors in case bugs creep in...
Diffstat (limited to 'lib/PublicInbox')
-rw-r--r--lib/PublicInbox/Listener.pm19
1 files changed, 19 insertions, 0 deletions
diff --git a/lib/PublicInbox/Listener.pm b/lib/PublicInbox/Listener.pm
index f6a5da69..821c3458 100644
--- a/lib/PublicInbox/Listener.pm
+++ b/lib/PublicInbox/Listener.pm
@@ -10,6 +10,13 @@ use Socket qw(SOL_SOCKET SO_KEEPALIVE IPPROTO_TCP TCP_NODELAY);
 use fields qw(post_accept);
 require IO::Handle;
 use PublicInbox::Syscall qw(EPOLLIN EPOLLEXCLUSIVE EPOLLET);
+use Errno qw(EAGAIN ECONNABORTED EPERM);
+
+# Warn on transient errors, mostly resource limitations.
+# EINTR would indicate the failure to set NonBlocking in systemd or similar
+my %ERR_WARN = map {;
+        eval("Errno::$_()") => $_
+} qw(EMFILE ENFILE ENOBUFS ENOMEM EINTR);
 
 sub new ($$$) {
         my ($class, $s, $cb) = @_;
@@ -35,6 +42,18 @@ sub event_step {
                 IO::Handle::blocking($c, 0); # no accept4 :<
                 $self->{post_accept}->($c, $addr, $sock);
                 $self->requeue;
+        } elsif ($! == EAGAIN || $! == ECONNABORTED || $! == EPERM) {
+                # EAGAIN is common and likely
+                # ECONNABORTED is common with bad connections
+                # EPERM happens if firewall rules prevent a connection
+                # on Linux (and everything that emulates Linux).
+                # Firewall rules are sometimes intentional, so we don't
+                # warn on EPERM to avoid being too noisy...
+                return;
+        } elsif (my $sym = $ERR_WARN{int($!)}) {
+                warn "W: accept(): $! ($sym)\n";
+        } else {
+                warn "BUG?: accept(): $!\n";
         }
 }