about summary refs log tree commit homepage
path: root/lib/PublicInbox/WwwStream.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-10-01 07:01:30 +0000
committerEric Wong <e@80x24.org>2019-10-01 07:10:29 +0000
commitdbb6c7b51862d0ea7438f5fb393d115ea46f1fab (patch)
tree2ac482805578bca7f29a894a65b87608eeaaead3 /lib/PublicInbox/WwwStream.pm
parent5981542ebbc555c6d7e5920c75ae3b3cb1727a4b (diff)
downloadpublic-inbox-dbb6c7b51862d0ea7438f5fb393d115ea46f1fab.tar.gz
While we avoid generating absolute URLs in most cases, our
"git clone" instructions and URL headers in mboxrd files
contain full URLs.

So do the same thing we do for WwwAtomStream and pre-generate
the full URL before Plack::App::URLMap changes $env->{PATH_INFO}
and $env->{SCRIPT_NAME} back to their original values.

Reported-by: edef <edef@edef.eu>
Link: https://public-inbox.org/meta/cover.0f97c47bb88db8b875be7497289d8fedd3b11991.1569296942.git-series.edef@edef.eu/
Diffstat (limited to 'lib/PublicInbox/WwwStream.pm')
-rw-r--r--lib/PublicInbox/WwwStream.pm13
1 files changed, 10 insertions, 3 deletions
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 7399b0ad..f5338c39 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -19,7 +19,15 @@ sub close {}
 
 sub new {
         my ($class, $ctx, $cb) = @_;
-        bless { nr => 0, cb => $cb || *close, ctx => $ctx }, $class;
+
+        my $base_url = $ctx->{-inbox}->base_url($ctx->{env});
+        chop $base_url; # no trailing slash for clone
+        bless {
+                nr => 0,
+                cb => $cb || *close,
+                ctx => $ctx,
+                base_url => $base_url,
+        }, $class;
 }
 
 sub response {
@@ -83,8 +91,7 @@ sub _html_end {
         my $desc = ascii_html($ibx->description);
 
         my (%seen, @urls);
-        my $http = $ibx->base_url($ctx->{env});
-        chop $http; # no trailing slash for clone
+        my $http = $self->{base_url};
         my $max = $ibx->max_git_epoch;
         my $dir = (split(m!/!, $http))[-1];
         if (defined($max)) { # v2