about summary refs log tree commit homepage
path: root/lib/PublicInbox/WwwStream.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-01-23 23:05:58 +0000
committerEric Wong <e@yhbt.net>2020-01-24 23:04:56 +0000
commit36db110eb3befcb28627d0f3d2d618aa3f1bf76c (patch)
tree02518e16fdab32559e2656f6e40f085379d178fe /lib/PublicInbox/WwwStream.pm
parent7d4858ea519cfe71cddc425ef4d39d6eea250b23 (diff)
downloadpublic-inbox-36db110eb3befcb28627d0f3d2d618aa3f1bf76c.tar.gz
Another place where List::Scalar::uniq doesn't make sense,
but there's a small op reduction to be had anyways.
Diffstat (limited to 'lib/PublicInbox/WwwStream.pm')
-rw-r--r--lib/PublicInbox/WwwStream.pm8
1 files changed, 3 insertions, 5 deletions
diff --git a/lib/PublicInbox/WwwStream.pm b/lib/PublicInbox/WwwStream.pm
index 8f5a6526..a724d069 100644
--- a/lib/PublicInbox/WwwStream.pm
+++ b/lib/PublicInbox/WwwStream.pm
@@ -89,12 +89,12 @@ sub _html_end {
         my $ibx = $ctx->{-inbox};
         my $desc = ascii_html($ibx->description);
 
-        my (%seen, @urls);
+        my @urls;
         my $http = $self->{base_url};
         my $max = $ibx->max_git_epoch;
         my $dir = (split(m!/!, $http))[-1];
+        my %seen = ($http => 1);
         if (defined($max)) { # v2
-                $seen{$http} = 1;
                 for my $i (0..$max) {
                         # old parts my be deleted:
                         -d "$ibx->{inboxdir}/git/$i.git" or next;
@@ -103,15 +103,13 @@ sub _html_end {
                         push @urls, "$url $dir/git/$i.git";
                 }
         } else { # v1
-                $seen{$http} = 1;
                 push @urls, $http;
         }
 
         # FIXME: epoch splits can be different in other repositories,
         # use the "cloneurl" file as-is for now:
         foreach my $u (@{$ibx->cloneurl}) {
-                next if $seen{$u};
-                $seen{$u} = 1;
+                next if $seen{$u}++;
                 push @urls, $u =~ /\Ahttps?:/ ? qq(<a\nhref="$u">$u</a>) : $u;
         }