diff options
| author | Eric Wong <e@80x24.org> | 2021-08-26 12:33:31 +0000 |
|---|---|---|
| committer | Eric Wong <e@80x24.org> | 2021-08-28 10:36:58 +0000 |
| commit | 5c8909925072804901e9c3b45bbf25446d379e7b (patch) | |
| tree | 32b55b97dc531395284dc9458634c9f5b8c4d5b8 /lib/PublicInbox/WwwStatic.pm | |
| parent | 26c635060dcae35feae836b02a18a6a11e408312 (diff) | |
| download | public-inbox-5c8909925072804901e9c3b45bbf25446d379e7b.tar.gz | |
The only place where we could return wide characters with -httpd
was the raw $INBOX_DIR/description text, which is now converted
to octets.
All daemon (HTTP/NNTP/IMAP) sockets are opened in binary mode,
so length() and bytes::length() are equivalent on reads. For
socket writes, any non-octet data would warn about wide characters
and we are strict in warnings with test_httpd.
All gzipped buffers are also octets, as is PublicInbox::Eml->body,
and anything from PerlIO objects ("git cat-file --batch" output,
filesystems), so bytes::length was unnecessary in all those places.
Diffstat (limited to 'lib/PublicInbox/WwwStatic.pm')
| -rw-r--r-- | lib/PublicInbox/WwwStatic.pm | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/WwwStatic.pm b/lib/PublicInbox/WwwStatic.pm index 29e4819d..b3476ab8 100644 --- a/lib/PublicInbox/WwwStatic.pm +++ b/lib/PublicInbox/WwwStatic.pm @@ -9,8 +9,8 @@ # functionality of nginx. package PublicInbox::WwwStatic; use strict; +use v5.10.1; use parent qw(Exporter); -use bytes (); use Fcntl qw(SEEK_SET O_RDONLY O_NONBLOCK); use POSIX qw(strftime); use HTTP::Date qw(time2str); @@ -318,7 +318,7 @@ sub dir_response ($$$) { "</head><body><pre>Index of $path_info_html</pre><hr><pre>\n"); $gzf->zmore(join("\n", @entries)); my $out = $gzf->zflush("</pre><hr></body></html>\n"); - $h->[3] = bytes::length($out); + $h->[3] = length($out); [ 200, $h, [ $out ] ] } |