about summary refs log tree commit homepage
path: root/lib/PublicInbox/WwwListing.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-07-05 23:27:25 +0000
committerEric Wong <e@yhbt.net>2020-07-06 20:01:15 +0000
commitf72164822464f630c56ac13edc6756987d1e48f6 (patch)
treeda17617a2da5d120d797bd89326bec40b9fe4474 /lib/PublicInbox/WwwListing.pm
parentf26183401e3abfb64ad82537151f2718ac889074 (diff)
downloadpublic-inbox-f72164822464f630c56ac13edc6756987d1e48f6.tar.gz
{gzip,noop}filter: ->zmore returns undef, always
This simplifies callers, as witnessed by the change to
WwwListing.  It adds overhead to NoopFilter, but NoopFilter
should see little use as nearly all HTTP clients request gzip.
Diffstat (limited to 'lib/PublicInbox/WwwListing.pm')
-rw-r--r--lib/PublicInbox/WwwListing.pm8
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/PublicInbox/WwwListing.pm b/lib/PublicInbox/WwwListing.pm
index 780c97e9..d641e6d5 100644
--- a/lib/PublicInbox/WwwListing.pm
+++ b/lib/PublicInbox/WwwListing.pm
@@ -109,7 +109,7 @@ sub html ($$) {
         my $h = [ 'Content-Type', 'text/html; charset=UTF-8',
                         'Content-Length', undef ];
         my $gzf = gzf_maybe($h, $env) || PublicInbox::NoopFilter::new();
-        my $out = $gzf->zmore('<html><head><title>' .
+        $gzf->zmore('<html><head><title>' .
                                 'public-inbox listing</title>' .
                                 '</head><body><pre>');
         my $code = 404;
@@ -122,11 +122,11 @@ sub html ($$) {
 
                 my $tmp = join("\n", map { ibx_entry(@$_, $env) } @$list);
                 my $l = PublicInbox::Linkify->new;
-                $out .= $gzf->zmore($l->to_html($tmp));
+                $gzf->zmore($l->to_html($tmp));
         } else {
-                $out .= $gzf->zmore('no inboxes, yet');
+                $gzf->zmore('no inboxes, yet');
         }
-        $out .= $gzf->zflush('</pre><hr><pre>'.
+        my $out = $gzf->zflush('</pre><hr><pre>'.
                                 PublicInbox::WwwStream::code_footer($env) .
                                 '</pre></body></html>');
         $h->[3] = bytes::length($out);