about summary refs log tree commit homepage
path: root/lib/PublicInbox/WWW.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-03-03 03:16:58 +0000
committerEric Wong <e@80x24.org>2016-03-03 03:21:27 +0000
commit3cda6050b7c8f73e7fd86f88efc5cd42d0c13f73 (patch)
treecb2eb271eb7c24235889da1ef7dbd2b3458351dc /lib/PublicInbox/WWW.pm
parent2d7d6d91b8894052b8b6088defaf7ea1711eba06 (diff)
downloadpublic-inbox-3cda6050b7c8f73e7fd86f88efc5cd42d0c13f73.tar.gz
Message-IDs should not be MIME encoded, but in case they are,
use the raw form for compatibility with ssoma and possibly
other tools.  This prevents a potential problem where a
malicious client could confuse our storage layer into indexing
incorrect contents.
Diffstat (limited to 'lib/PublicInbox/WWW.pm')
-rw-r--r--lib/PublicInbox/WWW.pm4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/WWW.pm b/lib/PublicInbox/WWW.pm
index 2acb4c83..369be686 100644
--- a/lib/PublicInbox/WWW.pm
+++ b/lib/PublicInbox/WWW.pm
@@ -147,8 +147,8 @@ sub invalid_list_mid {
                 if ($mid = mid2blob($ctx)) {
                         require Email::Simple;
                         use PublicInbox::MID qw/mid_clean/;
-                        $mid = Email::Simple->new($mid);
-                        $ctx->{mid} = mid_clean($mid->header('Message-ID'));
+                        my $s = Email::Simple->new($mid);
+                        $ctx->{mid} = mid_clean($s->header('Message-ID'));
                 }
         }
         undef;