diff options
| author | Eric Wong <e@yhbt.net> | 2020-01-05 23:23:35 +0000 |
|---|---|---|
| committer | Eric Wong <e@yhbt.net> | 2020-01-06 10:21:00 +0000 |
| commit | 55b707d788ce13696e4411389583e720ea6dab01 (patch) | |
| tree | 19fcea9f3da92c0183fdb5845c79aaefbe1d53c4 /lib/PublicInbox/ViewDiff.pm | |
| parent | 42f390c5e4d8e6619d234a43aa5397c9977cf070 (diff) | |
| download | public-inbox-55b707d788ce13696e4411389583e720ea6dab01.tar.gz | |
There's a bunch of leftover "require" and "use" statements we no longer need and can get rid of, along with some excessive imports via "use". IO::Handle usage isn't always obvious, so add comments describing why a package loads it. Along the same lines, document the tmpdir support as the reason we depend on File::Temp 0.19, even though every Perl 5.10.1+ user has it. While we're at it, favor "use" over "require", since it it gives us extra compile-time checking.
Diffstat (limited to 'lib/PublicInbox/ViewDiff.pm')
| -rw-r--r-- | lib/PublicInbox/ViewDiff.pm | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/ViewDiff.pm b/lib/PublicInbox/ViewDiff.pm index 4d72eb48..10d71004 100644 --- a/lib/PublicInbox/ViewDiff.pm +++ b/lib/PublicInbox/ViewDiff.pm @@ -12,7 +12,7 @@ use warnings; use base qw(Exporter); our @EXPORT_OK = qw(flush_diff); use URI::Escape qw(uri_escape_utf8); -use PublicInbox::Hval qw(ascii_html to_attr from_attr); +use PublicInbox::Hval qw(ascii_html to_attr); use PublicInbox::Git qw(git_unquote); # keep track of state so we can avoid redundant HTML tags for |