www: do not bump {over} refcnt on long responses

SQLite files may be replaced or removed by admins while
generating a large threads or mailbox responses.  Ensure we
don't hold onto DBI handles and associated file descriptors
past their cleanup.

1 files changed, 4 insertions, 2 deletions

diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 805e785b..069b9680 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -31,7 +31,9 @@ sub msg_page_i {
         my ($ctx, $eml) = @_;
         if ($eml) { # called by WwwStream::async_eml or getline
                 my $smsg = $ctx->{smsg};
-                $ctx->{smsg} = $ctx->{over}->next_by_mid(@{$ctx->{next_arg}});
+                my $over = $ctx->{ibx}->over;
+                $ctx->{smsg} = $over ? $over->next_by_mid(@{$ctx->{next_arg}})
+                                : $ctx->gone('over');
                 $ctx->{mhref} = ($ctx->{nr} || $ctx->{smsg}) ?
                                 "../${\mid_href($smsg->{mid})}/" : '';
                 my $obuf = $ctx->{obuf} = _msg_page_prepare_obuf($eml, $ctx);
@@ -70,7 +72,7 @@ sub msg_page {
         my ($ctx) = @_;
         my $ibx = $ctx->{ibx};
         $ctx->{-obfs_ibx} = $ibx->{obfuscate} ? $ibx : undef;
-        my $over = $ctx->{over} = $ibx->over or return no_over_html($ctx);
+        my $over = $ibx->over or return no_over_html($ctx);
         my ($id, $prev);
         my $next_arg = $ctx->{next_arg} = [ $ctx->{mid}, \$id, \$prev ];