about summary refs log tree commit homepage
path: root/lib/PublicInbox/View.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2021-10-23 18:20:44 -0600
committerEric Wong <e@80x24.org>2021-10-24 02:20:33 +0000
commit08b543eb6c67cc19ea8e86afe6b9494df79e2fea (patch)
tree12178b7b3dd008b630d31175f3e6684202397e1e /lib/PublicInbox/View.pm
parenta877fe97c753e7dc1803936e932adff566f7641d (diff)
downloadpublic-inbox-08b543eb6c67cc19ea8e86afe6b9494df79e2fea.tar.gz
The use of array-returning built-ins such as `grep' inside
arrayref declarations appears to result in permanently allocated
scratchpad space for caching according to my malloc inspector.

Thread skeletons get discarded every response, but multiple
skeletons can exist in memory at once, so do what we can to
prevent long-lived allocations from being made, here.

In other words, replacing constructs such as:

	my $foo = [ grep(...) ];

with:

	my @foo = grep(...);

Seems to ensure the mortality of the underlying array.
Diffstat (limited to 'lib/PublicInbox/View.pm')
-rw-r--r--lib/PublicInbox/View.pm4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/View.pm b/lib/PublicInbox/View.pm
index 116aa641..2e9cf705 100644
--- a/lib/PublicInbox/View.pm
+++ b/lib/PublicInbox/View.pm
@@ -1073,10 +1073,10 @@ sub _skel_ghost {
 }
 
 sub sort_ds {
-        [ sort {
+        @{$_[0]} = sort {
                 (eval { $a->topmost->{ds} } || 0) <=>
                 (eval { $b->topmost->{ds} } || 0)
-        } @{$_[0]} ];
+        } @{$_[0]};
 }
 
 # accumulate recent topics if search is supported