diff options
| author | Eric Wong <e@yhbt.net> | 2020-01-10 09:14:19 +0000 |
|---|---|---|
| committer | Eric Wong <e@yhbt.net> | 2020-01-11 06:32:08 +0000 |
| commit | 9f5a583694396f84056b9d92255bba0197b52bc8 (patch) | |
| tree | efece7a24babf0bfa9ad0f31abab5a119ce384ff /lib/PublicInbox/V2Writable.pm | |
| parent | 6d576feb27625abc36675b7b466265d4f06b2f26 (diff) | |
| download | public-inbox-9f5a583694396f84056b9d92255bba0197b52bc8.tar.gz | |
Most spawn and popen_rd callers die on failure to spawn, anyways, and some are missing checks entirely. This saves us a bunch of verbose error-checking code in callers. This also makes popen_rd more consistent, since it already dies on pipe creation failures.
Diffstat (limited to 'lib/PublicInbox/V2Writable.pm')
| -rw-r--r-- | lib/PublicInbox/V2Writable.pm | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/PublicInbox/V2Writable.pm b/lib/PublicInbox/V2Writable.pm index 6021de44..51794326 100644 --- a/lib/PublicInbox/V2Writable.pm +++ b/lib/PublicInbox/V2Writable.pm @@ -777,7 +777,6 @@ sub diff ($$$) { my $cmd = [ qw(diff -u), $an, $bn ]; print STDERR "# MID conflict <$mid>\n"; my $pid = spawn($cmd, undef, { 1 => 2 }); - defined $pid or die "diff failed to spawn $!"; waitpid($pid, 0) == $pid or die "diff did not finish"; unlink($an, $bn); } |