about summary refs log tree commit homepage
path: root/lib/PublicInbox/Tmpfile.pm
diff options
authorEric Wong <e@yhbt.net>2020-01-05 23:23:35 +0000
committerEric Wong <e@yhbt.net>2020-01-06 10:21:00 +0000
commit55b707d788ce13696e4411389583e720ea6dab01 (patch)
tree19fcea9f3da92c0183fdb5845c79aaefbe1d53c4 /lib/PublicInbox/Tmpfile.pm
parent42f390c5e4d8e6619d234a43aa5397c9977cf070 (diff)
There's a bunch of leftover "require" and "use" statements we no
longer need and can get rid of, along with some excessive
imports via "use".

IO::Handle usage isn't always obvious, so add comments
describing why a package loads it.  Along the same lines,
document the tmpdir support as the reason we depend on
File::Temp 0.19, even though every Perl 5.10.1+ user has it.

While we're at it, favor "use" over "require", since it it gives
us extra compile-time checking.
Diffstat (limited to 'lib/PublicInbox/Tmpfile.pm')
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/Tmpfile.pm b/lib/PublicInbox/Tmpfile.pm
index 28e87f88..05f359d8 100644
--- a/lib/PublicInbox/Tmpfile.pm
+++ b/lib/PublicInbox/Tmpfile.pm
@@ -7,7 +7,7 @@ use base qw(Exporter);
 our @EXPORT = qw(tmpfile);
 use Fcntl qw(:DEFAULT);
 use Errno qw(EEXIST);
-require File::Spec;
+use File::Spec;
 # use tmpfile instead of open(..., '+>', undef) so we can get an
 # unlinked filename which makes sense when viewed with lsof