about summary refs log tree commit homepage
path: root/lib/PublicInbox/Spawn.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-01-10 09:14:19 +0000
committerEric Wong <e@yhbt.net>2020-01-11 06:32:08 +0000
commit9f5a583694396f84056b9d92255bba0197b52bc8 (patch)
treeefece7a24babf0bfa9ad0f31abab5a119ce384ff /lib/PublicInbox/Spawn.pm
parent6d576feb27625abc36675b7b466265d4f06b2f26 (diff)
downloadpublic-inbox-9f5a583694396f84056b9d92255bba0197b52bc8.tar.gz
Most spawn and popen_rd callers die on failure to spawn,
anyways, and some are missing checks entirely.  This saves
us a bunch of verbose error-checking code in callers.

This also makes popen_rd more consistent, since it already
dies on pipe creation failures.
Diffstat (limited to 'lib/PublicInbox/Spawn.pm')
-rw-r--r--lib/PublicInbox/Spawn.pm1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 1c74a596..b02d5368 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -219,7 +219,6 @@ sub popen_rd {
         $opts ||= {};
         $opts->{1} = fileno($w);
         my $pid = spawn($cmd, $env, $opts);
-        return unless defined $pid;
         return ($r, $pid) if wantarray;
         my $ret = gensym;
         tie *$ret, 'PublicInbox::ProcessPipe', $pid, $r;