about summary refs log tree commit homepage
path: root/lib/PublicInbox/Spawn.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-02-28 11:28:33 +0000
committerEric Wong <e@80x24.org>2016-02-28 11:30:33 +0000
commit2ac2023fa416e31189708c355db8728abbd9ef2c (patch)
tree4d9eed94def3dfc7b6d7c0c5cb86bb734c84173c /lib/PublicInbox/Spawn.pm
parent8f090c1ff5e4eea068f20b30f1f79144aae936a3 (diff)
downloadpublic-inbox-2ac2023fa416e31189708c355db8728abbd9ef2c.tar.gz
We can rely on timely auto-destruction based on reference
counting; reducing the chance of redundant close(2) calls
which may hit the wront FD.

We do care about certain close calls (e.g. writing to a buffered
IO handle) if we require error-checking for write-integrity.  In
other cases, let things go out-of-scope so it can be freed
automatically after use.
Diffstat (limited to 'lib/PublicInbox/Spawn.pm')
-rw-r--r--lib/PublicInbox/Spawn.pm1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/PublicInbox/Spawn.pm b/lib/PublicInbox/Spawn.pm
index 51ad2692..02c5446f 100644
--- a/lib/PublicInbox/Spawn.pm
+++ b/lib/PublicInbox/Spawn.pm
@@ -171,7 +171,6 @@ sub popen_rd {
         $r->blocking($blocking) if defined $blocking;
         $opts->{1} = fileno($w);
         my $pid = spawn($cmd, $env, $opts);
-        close $w;
         return ($r, $pid) if wantarray;
         my $ret = gensym;
         tie *$ret, 'PublicInbox::ProcessPipe', $pid, $r;