about summary refs log tree commit homepage
path: root/lib/PublicInbox/SearchView.pm
diff options
authorEric Wong <e@80x24.org>2019-12-19 05:18:00 +0000
committerEric Wong <e@80x24.org>2019-12-20 03:09:26 +0000
commit3082849c654fdee12ad97396b4e39be3c4888c1d (patch)
tree429a5b1dd08b4bb101e5a32d615cccd140dcb8b0 /lib/PublicInbox/SearchView.pm
parent8d29cf132caf3de81986179b10746f31123c96b9 (diff)
Instead of only passing an Inbox object, we'll pass the $ctx
reference as PublicInbox::SearchView::mset_thread did.

So although mset_thread was wrong, we now make it's usage
of SearchThread::thread correct and update other callers to
favor the new style of passing the entire $ctx (with ->{-inbox})
instead of just the Inbox object.

This makes the thread skeleton at the bottom of the search
page to show subjects of messages, but unfortunately links to
non-existent #anchors.  The next commit will fix that.

While we're at it, favor "\&foo" over "*foo" since the former
makes the code reference (aka "function pointer) obvious so it
won't be confused for other things named "foo" in that
scope (e.g. $foo/@foo/%foo).
Diffstat (limited to 'lib/PublicInbox/SearchView.pm')
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index 78f2bd8b..566808e1 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -276,7 +276,7 @@ sub mset_thread {
         } ($mset->items) ]});
         my $r = $q->{r};
         my $rootset = PublicInbox::SearchThread::thread($msgs,
-                $r ? sort_relevance(\%pct) : *PublicInbox::View::sort_ds,
+                $r ? sort_relevance(\%pct) : \&PublicInbox::View::sort_ds,
         my $skel = search_nav_bot($mset, $q). "<pre>";
         $ctx->{-upfx} = '';