about summary refs log tree commit homepage
path: root/lib/PublicInbox/SearchView.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-05-25 01:44:46 +0000
committerEric Wong <e@80x24.org>2016-05-25 01:49:54 +0000
commit23a4e44bedabe5b8b651346cabc2a870c5377a30 (patch)
treee92220e935276cd1a2f466fa4bc6bf1e29fdb8e0 /lib/PublicInbox/SearchView.pm
parent64aea34d06f71828b0bdd6ae177b9bcf22d752b4 (diff)
downloadpublic-inbox-23a4e44bedabe5b8b651346cabc2a870c5377a30.tar.gz
git has stricter requirements for ident names (no '<>')
which Email::Address allows.

Even in 1.908, Email::Address also has an incomplete fix for
CVE-2015-7686 with a DoS-able regexp for comments.  Since we
don't care for or need all the RFC compliance of Email::Address,
avoiding it entirely may be preferable.

Email::Address will still be installed as a requirement for
Email::MIME, but it is only used by the
Email::MIME::header_str_set which we do not use
Diffstat (limited to 'lib/PublicInbox/SearchView.pm')
-rw-r--r--lib/PublicInbox/SearchView.pm1
1 files changed, 0 insertions, 1 deletions
diff --git a/lib/PublicInbox/SearchView.pm b/lib/PublicInbox/SearchView.pm
index e3dc22f7..0ae05052 100644
--- a/lib/PublicInbox/SearchView.pm
+++ b/lib/PublicInbox/SearchView.pm
@@ -176,7 +176,6 @@ sub tdump {
         $ctx->{searchview} = 1;
         tdump_ent($git, $state, $_, 0) for @rootset;
         PublicInbox::View::thread_adj_level($state, 0);
-        Email::Address->purge_cache;
 
         $fh->write(search_nav_bot($mset, $q). "\n\n" .
                         foot($ctx). '</pre></body></html>');