about summary refs log tree commit homepage
path: root/lib/PublicInbox/SearchThread.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-10-13 03:59:02 +0000
committerEric Wong <e@80x24.org>2016-10-13 04:01:16 +0000
commite76543b68aa384f328b19673681b5595f439376c (patch)
tree585d7961ed647ca113b6f3531088d1761866a277 /lib/PublicInbox/SearchThread.pm
parentc76585db3daa7910edf5f4c048d783b67e2c2315 (diff)
downloadpublic-inbox-e76543b68aa384f328b19673681b5595f439376c.tar.gz
This should reduce differences from the original Mail::Thread
code and hopefully make things easier-to-follow.
Diffstat (limited to 'lib/PublicInbox/SearchThread.pm')
-rw-r--r--lib/PublicInbox/SearchThread.pm38
1 files changed, 19 insertions, 19 deletions
diff --git a/lib/PublicInbox/SearchThread.pm b/lib/PublicInbox/SearchThread.pm
index 003a8d11..c6bd999c 100644
--- a/lib/PublicInbox/SearchThread.pm
+++ b/lib/PublicInbox/SearchThread.pm
@@ -49,27 +49,27 @@ sub _add_message ($$) {
         $this->{smsg} = $smsg;
 
         # B. For each element in the message's References field:
+        defined(my $refs = $smsg->{references}) or return;
+
         my $prev;
-        if (defined(my $refs = $smsg->{references})) {
-                foreach my $ref ($refs =~ m/<([^>]+)>/g) {
-                        # Find a Container object for the given Message-ID
-                        my $cont = _get_cont_for_id($self, $ref);
-
-                        # Link the References field's Containers together in
-                        # the order implied by the References header
-                        #
-                        # * If they are already linked don't change the
-                        #   existing links
-                        # * Do not add a link if adding that link would
-                        #   introduce a loop...
-                        if ($prev &&
-                                !$cont->{parent} &&  # already linked
-                                !$cont->has_descendent($prev) # would loop
-                           ) {
-                                $prev->add_child($cont);
-                        }
-                        $prev = $cont;
+        foreach my $ref ($refs =~ m/<([^>]+)>/g) {
+                # Find a Container object for the given Message-ID
+                my $cont = _get_cont_for_id($self, $ref);
+
+                # Link the References field's Containers together in
+                # the order implied by the References header
+                #
+                # * If they are already linked don't change the
+                #   existing links
+                # * Do not add a link if adding that link would
+                #   introduce a loop...
+                if ($prev &&
+                        !$cont->{parent} &&  # already linked
+                        !$cont->has_descendent($prev) # would loop
+                   ) {
+                        $prev->add_child($cont);
                 }
+                $prev = $cont;
         }
 
         # C. Set the parent of this message to be the last element in