about summary refs log tree commit homepage
path: root/lib/PublicInbox/SearchMsg.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2019-01-08 11:13:33 +0000
committerEric Wong <e@80x24.org>2019-01-08 19:28:02 +0000
commit7766a71df4cb715a240fd97a03dc0c31ab153c21 (patch)
tree22d6f9ad174b28c055e6881fca8948bb79beda96 /lib/PublicInbox/SearchMsg.pm
parentd7ceeaadbab7034eccb88b0c53b9538c1c92b25a (diff)
downloadpublic-inbox-7766a71df4cb715a240fd97a03dc0c31ab153c21.tar.gz
On a certain ugly /$INBOX/$MESSAGE_ID/T/ endpoint with 1000
messages in the thread, this cuts memory usage from 2.5M to 1.9M
(which still isn't great, but it's a start).
Diffstat (limited to 'lib/PublicInbox/SearchMsg.pm')
-rw-r--r--lib/PublicInbox/SearchMsg.pm19
1 files changed, 11 insertions, 8 deletions
diff --git a/lib/PublicInbox/SearchMsg.pm b/lib/PublicInbox/SearchMsg.pm
index 292efcee..722a1b94 100644
--- a/lib/PublicInbox/SearchMsg.pm
+++ b/lib/PublicInbox/SearchMsg.pm
@@ -82,18 +82,21 @@ sub load_expand {
         $self;
 }
 
+sub psgi_cull ($) {
+        my ($self) = @_;
+        from_name($self); # fill in {from_name} so we can delete {from}
+
+        # drop NNTP-only fields which aren't relevant to PSGI results:
+        # saves ~80K on a 200 item search result:
+        delete @$self{qw(from ts to cc bytes lines)};
+        $self;
+}
+
 # Only called by PSGI interface, not NNTP
 sub load_doc {
         my ($class, $doc) = @_;
         my $self = bless {}, $class;
-        my $smsg = load_expand($self, $doc);
-
-        from_name($smsg); # fill in {from_name} so we can delete {from}
-
-        # drop NNTP-only fields which aren't relevant to PSGI results:
-        # saves ~80K on a 200 item search result:
-        delete @$smsg{qw(from ts to cc bytes lines)};
-        $smsg;
+        psgi_cull(load_expand($self, $doc));
 }
 
 # :bytes and :lines metadata in RFC 3977