about summary refs log tree commit homepage
path: root/lib/PublicInbox/SearchIdxShard.pm
diff options
authorEric Wong <e@80x24.org>2020-11-28 07:06:50 +0000
committerEric Wong <e@80x24.org>2020-11-28 20:49:56 +0000
commit44de182766037948d62bc2a8ba924de2264dd5fc (patch)
tree2bfb0fe5fd96861cc9656689cfab98d5ca7e56b4 /lib/PublicInbox/SearchIdxShard.pm
parentc2f82b2e27e1b3c11a4c0b00b90829a4ee99c602 (diff)
We were accidentally adding "\n" to terms (which Xapian happily
accepts), causing incompatibilities when enabling parallel
sharding in some invocations of -extindex but not others.

This is an extindex incompatibility and starting a new extindex
will be required to take advantage of in-development features,
so it's not urgent to start another one, either.
(other incompatible things may happen before a 1.7 release)
Diffstat (limited to 'lib/PublicInbox/SearchIdxShard.pm')
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/PublicInbox/SearchIdxShard.pm b/lib/PublicInbox/SearchIdxShard.pm
index 875a9ec9..dcfeb0be 100644
--- a/lib/PublicInbox/SearchIdxShard.pm
+++ b/lib/PublicInbox/SearchIdxShard.pm
@@ -83,11 +83,13 @@ sub shard_worker_loop ($$$$$) {
                 } elsif ($line =~ s/\A\+X //) {
                         my ($len, $docid, $oid, $eidx_key) =
                                                         split(/ /, $line, 4);
+                        chomp $eidx_key;
                         $self->add_eidx_info($docid, $oid, $eidx_key,
                                                         eml($r, $len));
                 } elsif ($line =~ s/\A-X //) {
                         my ($len, $docid, $oid, $eidx_key) =
                                                         split(/ /, $line, 4);
+                        chomp $eidx_key;
                         $self->remove_eidx_info($docid, $oid, $eidx_key,
                                                         eml($r, $len));
                 } else {