diff options
author | Eric Wong <e@80x24.org> | 2019-01-05 11:00:52 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-01-05 23:16:30 +0000 |
commit | 789ac5b0119d8d878380bbe8b3de4c7630460148 (patch) | |
tree | 1cd93f45cdd5800983eaf20b3f70ff10850c34d3 /lib/PublicInbox/SearchIdx.pm | |
parent | 97c6b564fd79e47ae6fca8de273c2aeaf2f5bea5 (diff) | |
download | public-inbox-789ac5b0119d8d878380bbe8b3de4c7630460148.tar.gz |
The new t/*filter_rubylang.t tests call -index immediately after -init, which causes confusing messages to show up to the end user. Check the validity of the ref before calling "git-log".
Diffstat (limited to 'lib/PublicInbox/SearchIdx.pm')
-rw-r--r-- | lib/PublicInbox/SearchIdx.pm | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index 76f3f33a..fd48169d 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -607,6 +607,17 @@ sub _git_log { my ($self, $range) = @_; my $git = $self->{git}; + if (index($range, '..') < 0) { + # don't show annoying git errrors to users who run -index + # on empty inboxes + $git->qx(qw(rev-parse -q --verify), "$range^0"); + if ($?) { + open my $fh, '<', '/dev/null' or + die "failed to open /dev/null: $!\n"; + return $fh; + } + } + # Count the new files so they can be added newest to oldest # and still have numbers increasing from oldest to newest my $fcount = 0; |