about summary refs log tree commit homepage
path: root/lib/PublicInbox/RepoGitSnapshot.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2017-02-15 22:35:18 +0000
committerEric Wong <e@80x24.org>2017-02-16 04:27:50 +0000
commitf6244586ba4f5a5e7575e1254be8c9bbe303fce9 (patch)
treed1a8dd757b632f8cff66e3878f7cfc01e6e2f12d /lib/PublicInbox/RepoGitSnapshot.pm
parent993dc7a772b10deda15733c8e750d98bf4d27bd0 (diff)
downloadpublic-inbox-f6244586ba4f5a5e7575e1254be8c9bbe303fce9.tar.gz
Query strings make endpoint caching more difficult since
they're order-independent.  They are also more likely lost
or truncated inadvertantly when copy+pasting, so try to
avoid them for default endpoints.

There's still some things which are broken and followup
commits will be needed to fix them.
Diffstat (limited to 'lib/PublicInbox/RepoGitSnapshot.pm')
-rw-r--r--lib/PublicInbox/RepoGitSnapshot.pm4
1 files changed, 1 insertions, 3 deletions
diff --git a/lib/PublicInbox/RepoGitSnapshot.pm b/lib/PublicInbox/RepoGitSnapshot.pm
index e05ad80c..9ba4c04a 100644
--- a/lib/PublicInbox/RepoGitSnapshot.pm
+++ b/lib/PublicInbox/RepoGitSnapshot.pm
@@ -36,9 +36,7 @@ our %FMT_TYPES = (
 sub call_git_snapshot ($$) { # invoked by PublicInbox::RepoBase::call
         my ($self, $req) = @_;
 
-        my @extra = @{$req->{extra}};
-        my $ref = shift @extra;
-        return $self->r(404) if (!defined $ref) || scalar(@extra);
+        my $ref = $req->{-tip};
         my $orig_fn = $ref;
 
         # just in case git changes refname rules, don't allow wonky filenames