about summary refs log tree commit homepage
path: root/lib/PublicInbox/Qspawn.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-04-17 09:33:31 +0000
committerEric Wong <e@yhbt.net>2020-04-21 05:51:38 +0000
commite700c37c0186915253d639462cfa403fd9fc964f (patch)
treed42c6362ad1c4f1e9e0b0005147e01727148d041 /lib/PublicInbox/Qspawn.pm
parentd5eac0c11bc8b71d5e45b442e8cd97507825a62c (diff)
downloadpublic-inbox-e700c37c0186915253d639462cfa403fd9fc964f.tar.gz
It seems no longer necessary to workaround this Perl 5.16.3 bug
after the removal of anonymous subs from all of our internal
code in
https://public-inbox.org/meta/20191225075104.22184-1-e@80x24.org/

Tested with repeated clones (both aborted and completed)
in a CentOS 7.x VM which was once able to reproduce leaks
before the workaround appeared in 2fc42236f72ad16a
("qspawn: workaround Perl 5.16.3 leak, re-enable Deflater")

Cc: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Diffstat (limited to 'lib/PublicInbox/Qspawn.pm')
-rw-r--r--lib/PublicInbox/Qspawn.pm4
1 files changed, 0 insertions, 4 deletions
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm
index aebcb1f7..c09e8d2c 100644
--- a/lib/PublicInbox/Qspawn.pm
+++ b/lib/PublicInbox/Qspawn.pm
@@ -281,10 +281,6 @@ sub psgi_return_init_cb {
                                         ${$self->{hdr_buf}}, $filter);
                 $wcb->($r);
         }
-
-        # Workaround a leak under Perl 5.16.3 when combined with
-        # Plack::Middleware::Deflater:
-        $wcb = undef;
 }
 
 sub psgi_return_start { # may run later, much later...