diff options
author | Eric Wong <e@80x24.org> | 2019-01-27 03:30:30 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-01-27 03:30:30 +0000 |
commit | cee59522e00810f508aabce5a46e63bddcc203cc (patch) | |
tree | 9557638024ef85af670f0b9643126a7b683f7a17 /lib/PublicInbox/Qspawn.pm | |
parent | 84d1e7fdf92e2658cf539e35ce779638e2f10670 (diff) | |
download | public-inbox-cee59522e00810f508aabce5a46e63bddcc203cc.tar.gz |
The raw value of $? isn't very useful, generally.
Diffstat (limited to 'lib/PublicInbox/Qspawn.pm')
-rw-r--r-- | lib/PublicInbox/Qspawn.pm | 11 |
1 files changed, 10 insertions, 1 deletions
diff --git a/lib/PublicInbox/Qspawn.pm b/lib/PublicInbox/Qspawn.pm index 6859a8af..913fac81 100644 --- a/lib/PublicInbox/Qspawn.pm +++ b/lib/PublicInbox/Qspawn.pm @@ -30,13 +30,22 @@ sub _do_spawn { $cb->($self->{rpipe}); } +sub child_err ($) { + my ($child_error) = @_; # typically $? + my $exitstatus = ($child_error >> 8) or return; + my $sig = $child_error & 127; + my $msg = "exit status=$exitstatus"; + $msg .= " signal=$sig" if $sig; + $msg; +} + sub finish ($) { my ($self) = @_; my $limiter = $self->{limiter}; my $running; if (delete $self->{rpipe}) { my $pid = delete $self->{pid}; - $self->{err} = $pid == waitpid($pid, 0) ? $? : + $self->{err} = $pid == waitpid($pid, 0) ? child_err($?) : "PID:$pid still running?"; $running = --$limiter->{running}; } |