about summary refs log tree commit homepage
path: root/lib/PublicInbox/Over.pm
diff options
context:
space:
mode:
authorEric Wong <e@yhbt.net>2020-08-20 20:24:50 +0000
committerEric Wong <e@yhbt.net>2020-08-20 21:11:18 +0000
commit5a69dffc4155c8810dd8f2f3474f7a8a5c6d16a2 (patch)
tree4f2bea8a7bd03dd46a663f5e04cccebf19977d90 /lib/PublicInbox/Over.pm
parentc703745bcd09af545ef1bd320c895778081488d2 (diff)
downloadpublic-inbox-5a69dffc4155c8810dd8f2f3474f7a8a5c6d16a2.tar.gz
Instead of loading one article at-a-time from over.sqlite3, we
can use SQL to mass-load IN (?,?, ...) all results with a single
SQLite query.  Despite SQLite being in-process and having no
network latency, the reduction in SQL query executions from
loading multiple rows at once speeds things up significantly.

We'll keep the over->get_art optimizations from the previous
commit, since it still speeds up long-lived responses, slightly.
Diffstat (limited to 'lib/PublicInbox/Over.pm')
-rw-r--r--lib/PublicInbox/Over.pm9
1 files changed, 9 insertions, 0 deletions
diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index 80e57e62..a055b4cd 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -104,6 +104,15 @@ ORDER BY num ASC
 
 }
 
+sub get_all {
+        my $self = shift;
+        my $nr = scalar(@_) or return [];
+        my $in = '?' . (',?' x ($nr - 1));
+        do_get($self, <<"", { cull => 1, limit => $nr }, @_);
+SELECT num,ds,ddd FROM over WHERE num IN ($in)
+
+}
+
 sub nothing () { wantarray ? (0, []) : [] };
 
 sub get_thread {