about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTPD.pm
diff options
context:
space:
mode:
authorJonathan Corbet <corbet@lwn.net>2018-10-13 15:42:20 -0600
committerEric Wong <e@80x24.org>2018-10-16 03:48:39 +0000
commitdd7049951c052c541efe3d1bb6de8950512027a5 (patch)
tree33a44dccc40e63cfc7245ef67af8641cbbbd6ea7 /lib/PublicInbox/NNTPD.pm
parenta118d58a402bd31b5cd728a183305581b7d5557e (diff)
downloadpublic-inbox-dd7049951c052c541efe3d1bb6de8950512027a5.tar.gz
RFC 5536 sec 3.2.14 says that the server-name in an Xref line is "which
news server generated the header field"; indeed, that is necessary for
newsreaders like gnus to handle references properly.  So pick up the server
name from the config if available (the first name if there's more than
one), from the host name otherwise, and use it rather than the domain
name of the list server.

Tests have been adjusted to match the new behavior.
Diffstat (limited to 'lib/PublicInbox/NNTPD.pm')
-rw-r--r--lib/PublicInbox/NNTPD.pm10
1 files changed, 10 insertions, 0 deletions
diff --git a/lib/PublicInbox/NNTPD.pm b/lib/PublicInbox/NNTPD.pm
index 117c9c03..32848d7c 100644
--- a/lib/PublicInbox/NNTPD.pm
+++ b/lib/PublicInbox/NNTPD.pm
@@ -6,15 +6,25 @@
 package PublicInbox::NNTPD;
 use strict;
 use warnings;
+use Sys::Hostname;
 require PublicInbox::Config;
 
 sub new {
         my ($class) = @_;
+        my $pi_config = PublicInbox::Config->new;
+        my $name = $pi_config->{'publicinbox.nntpserver'};
+        if (!defined($name) or $name eq '') {
+                $name = hostname;
+        } elsif (ref($name) eq 'ARRAY') {
+                $name = $name->[0];
+        }
+
         bless {
                 groups => {},
                 err => \*STDERR,
                 out => \*STDOUT,
                 grouplist => [],
+                servername => $name,
         }, $class;
 }