about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTP.pm
diff options
authorEric Wong <e@80x24.org>2021-06-24 05:50:04 +0000
committerEric Wong <e@80x24.org>2021-06-24 12:59:40 +0000
commit9c42ece6dfddf4156dc3016e2fa8835bf3d8aca1 (patch)
treec47b1ae3c5e3817eb67337152f8d1e27e3238f2b /lib/PublicInbox/NNTP.pm
parent5ef37f4a13e2be711ef074dc2cd9994005273117 (diff)
While both git and libgit2 take around 16 minutes to load 100K
alternates there's already a proposed patch to make git faster:


It's also easier to patch and install git locally since the
git.git build system defaults to prefix=$HOME and dealing with
dynamic linking with libgit2 is more difficult for end users
relying on Inline::C.

libgit2 remains in use for the non-ALL.git case, but maybe it's
not necessary (libgit2 is significantly slower than git in
Debian 10 due to SHA-1 collision checking).
Diffstat (limited to 'lib/PublicInbox/NNTP.pm')
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index f7d99913..9df47133 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -515,7 +515,7 @@ found:
                 $smsg->{nntp_code} = $code;
                 set_art($self, $art);
                 # this dereferences to `undef'
-                ${git_async_cat($ibx->git, $smsg->{blob}, \&blob_cb, $smsg)};
+                ${ibx_async_cat($ibx, $smsg->{blob}, \&blob_cb, $smsg)};
@@ -549,7 +549,7 @@ sub msg_hdr_write ($$) {
-sub blob_cb { # called by git->cat_async via git_async_cat
+sub blob_cb { # called by git->cat_async via ibx_async_cat
         my ($bref, $oid, $type, $size, $smsg) = @_;
         my $self = $smsg->{nntp};
         my $code = $smsg->{nntp_code};