about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTP.pm
diff options
authorEric Wong <e@yhbt.net>2020-07-05 23:27:58 +0000
committerEric Wong <e@yhbt.net>2020-07-06 20:01:15 +0000
commit54c25a9cfb9a5eee44672b126eb75b9bb20aa957 (patch)
tree8d73d6592f4ecacafd6e94faffbb30657436c1cf /lib/PublicInbox/NNTP.pm
parenta4d8c547df4abf7bd06d4e7eccddfeabb4fc04f7 (diff)
Since -edit and -purge should be rare and TOCTOU around them
rarer still; missing {blobs} could be indicative of a real bug
elsewhere.  Warn on them.

And I somehow ended up with 3 different field names for Inbox
objects.  Perhaps they'll be made consistent in the future.
Diffstat (limited to 'lib/PublicInbox/NNTP.pm')
1 files changed, 1 insertions, 0 deletions
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index 9d91544a..87ddf7a4 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -523,6 +523,7 @@ sub blob_cb { # called by git->cat_async via git_async_cat
         if (!defined($oid)) {
                 # it's possible to have TOCTOU if an admin runs
                 # public-inbox-(edit|purge), just move onto the next message
+                warn "E: $smsg->{blob} missing in $self->{ng}->{inboxdir}\n";
                 return $self->requeue;
         } elsif ($smsg->{blob} ne $oid) {