about summary refs log tree commit homepage
path: root/lib/PublicInbox/NNTP.pm
diff options
authorEric Wong <e@yhbt.net>2020-04-18 03:38:53 +0000
committerEric Wong <e@yhbt.net>2020-04-19 08:51:29 +0000
commit0c586dc64b3b6642a894e125d09df446667a4079 (patch)
tree38d6b349b64e6395e1910aaae2ef450b06d96a13 /lib/PublicInbox/NNTP.pm
parent92de3139920992bfad32ef927153f27addfdc72c (diff)
It's unnecessary overhead for anything which does Email::MIME
parsing.  It was never done for v2 indexing, even though v1->v2
conversions did NOT remove those From_ lines.  There was never a
need to remote From_ lines the v1 SearchIdx paths, either.

Hitting a /$INBOX_URL/$MSGID/T/ endpoint with an 18 message
thread reveals a ~0.5% speed improvement.  This will become
more apparent when we have a faster MIME parser.
Diffstat (limited to 'lib/PublicInbox/NNTP.pm')
1 files changed, 2 insertions, 0 deletions
diff --git a/lib/PublicInbox/NNTP.pm b/lib/PublicInbox/NNTP.pm
index d1f75f6f..c79f198b 100644
--- a/lib/PublicInbox/NNTP.pm
+++ b/lib/PublicInbox/NNTP.pm
@@ -506,6 +506,8 @@ sub set_art {
 sub msg_hdr_write ($$$) {
         my ($self, $hdr, $body_follows) = @_;
         $hdr = $hdr->as_string;
+        # fixup old bug from import (pre-a0c07cba0e5d8b6a)
+        $hdr =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s;
         $hdr =~ s/(?<!\r)\n/\r\n/sg; # Alpine barfs without this