diff options
| author | Eric Wong <e@yhbt.net> | 2020-07-07 20:37:35 +0000 |
|---|---|---|
| committer | Eric Wong <e@yhbt.net> | 2020-07-10 11:27:06 +0000 |
| commit | 7f454bace0442cd5ce22068ec1e098e964d82778 (patch) | |
| tree | 1a3ba0012aa75a3a8a427a275c2b46ffce60813b /lib/PublicInbox/MboxGz.pm | |
| parent | bc18c05b1681acc9a468b298c34b12ca4db3e5bb (diff) | |
| download | public-inbox-7f454bace0442cd5ce22068ec1e098e964d82778.tar.gz | |
Returning an empty string for a filename makes no sense, so instead return `undef' so the caller can setup a fallback using the "//" operator. This fixes uninitialized variable warnings because split() on an empty string returns `undef', which caused to_filename to warn on s// and tr// ops.
Diffstat (limited to 'lib/PublicInbox/MboxGz.pm')
| -rw-r--r-- | lib/PublicInbox/MboxGz.pm | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/lib/PublicInbox/MboxGz.pm b/lib/PublicInbox/MboxGz.pm index fdd16f68..967af9c6 100644 --- a/lib/PublicInbox/MboxGz.pm +++ b/lib/PublicInbox/MboxGz.pm @@ -24,8 +24,7 @@ sub mbox_gz { $self->{cb} = $cb; $self->{base_url} = $self->{-inbox}->base_url($self->{env}); $self->{gz} = PublicInbox::GzipFilter::gzip_or_die(); - $fn = to_filename($fn // 'no-subject'); - $fn = 'no-subject' if $fn eq ''; + $fn = to_filename($fn // '') // 'no-subject'; # http://www.iana.org/assignments/media-types/application/gzip bless $self, __PACKAGE__; my $res_hdr = [ 'Content-Type' => 'application/gzip', |