about summary refs log tree commit homepage
path: root/lib/PublicInbox/Linkify.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2016-12-24 11:52:44 +0000
committerEric Wong <e@80x24.org>2016-12-24 19:41:03 +0000
commitd9e9c8ed84a15c7fdf8fa57e82fcec9de7ecba87 (patch)
tree31ae322d2a4280aa55059716fe01ad5628609e95 /lib/PublicInbox/Linkify.pm
parentf083ef6b36fcfe5bea35427636fc8aff4e729ef6 (diff)
downloadpublic-inbox-d9e9c8ed84a15c7fdf8fa57e82fcec9de7ecba87.tar.gz
This results in over 1% speedup doing $MESSAGE_ID/T/ HTML
generation for a 368-message thread.
Diffstat (limited to 'lib/PublicInbox/Linkify.pm')
-rw-r--r--lib/PublicInbox/Linkify.pm17
1 files changed, 7 insertions, 10 deletions
diff --git a/lib/PublicInbox/Linkify.pm b/lib/PublicInbox/Linkify.pm
index acd2a47e..8e1728c7 100644
--- a/lib/PublicInbox/Linkify.pm
+++ b/lib/PublicInbox/Linkify.pm
@@ -22,11 +22,10 @@ my $LINK_RE = qr{(\()?\b((?:ftps?|https?|nntps?|gopher)://
                  (?:\#[a-z0-9\-\._~!\$\&\';\(\)\*\+,;=:@/%\?]+)?
                  )}xi;
 
-sub new { bless {}, shift }
+sub new { bless {}, $_[0] }
 
 sub linkify_1 {
-        my ($self, $s) = @_;
-        $s =~ s!$LINK_RE!
+        $_[1] =~ s!$LINK_RE!
                 my $beg = $1 || '';
                 my $url = $2;
                 my $end = '';
@@ -50,19 +49,17 @@ sub linkify_1 {
 
                 # only escape ampersands, others do not match LINK_RE
                 $url =~ s/&/&#38;/g;
-                $self->{$key} = $url;
+                $_[0]->{$key} = $url;
                 $beg . 'PI-LINK-'. $key . $end;
         !ge;
-        $s;
+        $_[1];
 }
 
 sub linkify_2 {
-        my ($self, $s) = @_;
-
         # Added "PI-LINK-" prefix to avoid false-positives on git commits
-        $s =~ s!\bPI-LINK-([a-f0-9]{40})\b!
+        $_[1] =~ s!\bPI-LINK-([a-f0-9]{40})\b!
                 my $key = $1;
-                my $url = $self->{$key};
+                my $url = $_[0]->{$key};
                 if (defined $url) {
                         "<a\nhref=\"$url\">$url</a>";
                 } else {
@@ -70,7 +67,7 @@ sub linkify_2 {
                         $key;
                 }
         !ge;
-        $s;
+        $_[1];
 }
 
 1;